-
-
Notifications
You must be signed in to change notification settings - Fork 218
Fix parallel Monte Carlo simulation showing incorrect iteration count #885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parallel Monte Carlo simulation showing incorrect iteration count #885
Conversation
|
@copilot don't forget to include this PR in the CHANGELOG.md file! Keep the same formatting please. |
Gui-FernandesBR
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to test it before closing the associated issue
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #885 +/- ##
===========================================
+ Coverage 80.27% 80.35% +0.08%
===========================================
Files 104 106 +2
Lines 12769 13010 +241
===========================================
+ Hits 10250 10454 +204
- Misses 2519 2556 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…y increasing completed count Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
Co-authored-by: Gui-FernandesBR <63590233+Gui-FernandesBR@users.noreply.github.com>
8d3e803 to
7cfc5a5
Compare
sim_idxis passed directly, but simulations complete out of ordercompleted_countcounter to_SimMonitorclass to track completed simulationsprint_update_status()method to usecompleted_countinstead ofsim_idxand change label from "Current iteration" to "Iterations completed"completed_countin the method when called (since it's always called within mutex-protected section)Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.