Skip to content

fix(list_worktrees): detect detached via 'detached' marker, not HEAD line#13

Merged
RodrigoEspinosa merged 1 commit intomasterfrom
add-list-worktrees-tests-12611007312094146683
Apr 11, 2026
Merged

fix(list_worktrees): detect detached via 'detached' marker, not HEAD line#13
RodrigoEspinosa merged 1 commit intomasterfrom
add-list-worktrees-tests-12611007312094146683

Conversation

@RodrigoEspinosa
Copy link
Copy Markdown
Owner

🎯 What: The testing gap addressed
The list_worktrees function in bin/wt lacked test coverage, which could lead to regressions.

📊 Coverage: What scenarios are now tested
The new tests/list_worktrees.bats file covers four main scenarios:

  1. Listing all worktrees when no target is specified.
  2. Fetching the path for a specific branch.
  3. Fetching the path for a detached head using the (detached) specifier.
  4. Correctly outputting nothing for a non-existent branch.

Result: The improvement in test coverage
The codebase now ensures list_worktrees accurately maps branch names, generic strings, and paths correctly under various git worktree outputs, including detached states. It also allowed fixing an implicit bug where list_worktrees misidentified any worktree as detached because git worktree list --porcelain prints a HEAD block for all worktrees; now it explicitly looks for the detached keyword.


PR created automatically by Jules for task 12611007312094146683 started by @RodrigoEspinosa

This commit adds BATS test coverage for the `list_worktrees` function
in `bin/wt`. It introduces tests for scenarios where target is absent
(listing all worktrees), searching by branch name, and searching for
detached head paths.

It also fixes a bug in `bin/wt` where detached worktrees were identified
by `^HEAD ` instead of `^detached`. The format for `git worktree list --porcelain`
always emits `HEAD` lines, but `detached` specifically replaces the `branch`
line for detached worktrees.

Co-authored-by: RodrigoEspinosa <1685621+RodrigoEspinosa@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@RodrigoEspinosa RodrigoEspinosa changed the title 🧪 Add tests for list_worktrees and fix parsing bug fix(list_worktrees): detect detached via 'detached' marker, not HEAD line Apr 11, 2026
@RodrigoEspinosa RodrigoEspinosa merged commit 3f9477c into master Apr 11, 2026
@RodrigoEspinosa RodrigoEspinosa deleted the add-list-worktrees-tests-12611007312094146683 branch April 11, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant