Open
Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
| if not check_some_critical_condition(r): | ||
| return None | ||
| return r | ||
| return None if not check_some_critical_condition(r) else r |
Author
There was a problem hiding this comment.
Function filter_for_foo refactored with the following changes:
- Lift code into else after jump in control flow (
reintroduce-else) - Replace if statement with if expression (
assign-if-exp)
Comment on lines
40
to
-45
|
|
||
| if res is not None: | ||
| #continue processing | ||
| pass |
Author
There was a problem hiding this comment.
Lines 42-45 refactored with the following changes:
- Remove redundant conditional (
remove-redundant-if)
This removes the following comments ( why? ):
#continue processing
Comment on lines
-332
to
+327
| #Bad | ||
|
|
||
| f = open("file.txt","r") | ||
| content = f.read() | ||
| f.close() | ||
|
|
||
| with open("file.txt","r") as f: | ||
| content = f.read() |
Author
There was a problem hiding this comment.
Lines 332-385 refactored with the following changes:
- Use
withwhen opening file to ensure closure (ensure-file-closed) - Use f-string instead of string concatenation [×2] (
use-fstring-for-concatenation) - Remove unnecessary calls to
str()from formatted values in f-strings (remove-str-from-fstring)
| """Return list of HTML theme paths.""" | ||
| cur_dir = os.path.abspath(os.path.dirname(os.path.dirname(__file__))) | ||
| return cur_dir | ||
| return os.path.abspath(os.path.dirname(os.path.dirname(__file__))) |
Author
There was a problem hiding this comment.
Function get_html_theme_path refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
| """Return list of HTML theme paths.""" | ||
| cur_dir = os.path.abspath(os.path.dirname(os.path.dirname(__file__))) | ||
| return cur_dir | ||
| return os.path.abspath(os.path.dirname(os.path.dirname(__file__))) |
Author
There was a problem hiding this comment.
Function get_html_theme_path refactored with the following changes:
- Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branch
masterrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
masterbranch, then run:Help us improve this pull request!