Replies: 4 comments 1 reply
-
|
There's scope for a lot of improvements here. The error message should be clearer but it would require an explicit check to see if the dependency exists (such as running
The error implementation itself isn't best practice, if I were to revisit it I'd probably:
Regarding eyeD3 specifically, the implementation is quite lazy and it could be removed entirely:
I primarily recommend using the Docker image as it bundles all the dependencies solving issues like you've seen. Unfortunately I don't have much time to dedicate to caesura at present so this will likely go unaddressed but contributions are welcome. |
Beta Was this translation helpful? Give feedback.
-
|
I've been looking into this and the behavior you're requesting already exists. If eyeD3 hits an error when being spawned it's passed to In `command_error() we explicitly check if it's a NotFound error and if so use the message "Could not find dependency: {program}" caesura/src/utils/errors/error.rs Lines 28 to 32 in 4941a22 But in your case it's a permission denied error? |
Beta Was this translation helpful? Give feedback.
-
|
Hey, thanks for checking up on this! I'm glad we have support for this already -- we might not need to add what I'm asking for. Still curious what's going on though..
It's not available at all as far as I can tell: I'm running this on Whatbox, they're using Gentoo (and are not keen on installing https://packages.gentoo.org/packages/dev-python/eyed3). For what it's worth, this is the It's weird that the error handling isn't catching this. I am no Rust expert, but surely this means that the error is something other than I'm happy to assist in chasing this down anyway I can. |
Beta Was this translation helpful? Give feedback.
-
|
Resolved in fd260aa and 3c57b83 If the And for your case where there is a permission issue: |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
First off, thanks for a great tool!
I re-compiled caesura 0.26.0 recently on a new machine and got this error:
The upload went through, but I didn't immediately understand what the error was about. It took me a few seconds to realise that this was due to the eyeD3 executable missing. Please note that I am not using Docker but am rather running caesura directly.
Could we make the error message clearer here? Ideally I'd like to see "command not found: eyeD3" or similar.
Beta Was this translation helpful? Give feedback.
All reactions