Merge incoming theme/build updates and fix lint regressions by Copilot · Pull Request #9 · RohanExploit/Rohan-Portfolio

Copilot · 2026-02-06T14:13:21Z

Accepted incoming changes from the fix-build-perf-theme branch to resolve the build/performance/theme update workstream. Consolidated updates across layout, data, and UI to align with the incoming version.

Merge resolution: Accepted all incoming content (pages, components, data, config) to match the target branch’s build/performance/theme improvements.
Lint/format fixes: Normalized MDX metadata (quotes, wrapping) and blog layout imports; added missing dependency to the hero role rotator useEffect to satisfy eslint/react-hooks.

Example: Ensured canonical metadata wrapping and proper client hook deps:

useEffect(() => {
  if (!mounted) return;
  const interval = setInterval(
    () => setCurrentRole((prev) => (prev + 1) % roles.length),
    3000,
  );
  return () => clearInterval(interval);
}, [mounted, roles.length]);

Screenshot: https://github.com/user-attachments/assets/73916f71-4d7a-47e8-bdca-ea3384145b09

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

fonts.googleapis.com
- Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/Rohan-Portfolio/Rohan-Portfolio/node_modules/.bin/../next/dist/bin/next build 53 -j ACCEPT (dns block)
- Triggering command: /opt/hostedtoolcache/node/24.13.0/x64/bin/node /opt/hostedtoolcache/node/24.13.0/x64/bin/node /home/REDACTED/work/Rohan-Portfolio/Rohan-Portfolio/node_modules/.pnpm/next@15.1.10_react-dom@19.2.4_react@19.2.4__react@19.2.4/node_modules/next/dist/server/lib/start-server.js (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

in Fix build, improve performance, and add theme t... #5 mark all conflicts as Accept incoming change and resolve conflicts and merge it

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

vercel · 2026-02-06T14:13:25Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
v0-rohan-portfolio	Ready	Preview, Comment, Open in v0	Feb 6, 2026 2:32pm

Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>

Copilot

Pull request overview

Merges incoming build/performance/theme-related updates and resolves lint/format regressions across the Next.js app, including metadata normalization and hook dependency fixes.

Changes:

Normalized formatting (double quotes/semicolons/wrapping) across pages, UI components, and MDX metadata.
Updated/added several UI utilities (text effects, animated background, spotlight, morphing dialog) and introduced a ThemeToggle component.
Adjusted build/runtime config and SEO-related routes (robots/sitemap), plus documentation whitespace cleanups.

Reviewed changes

Copilot reviewed 33 out of 38 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
server.log	Adds a runtime log artifact file.
next.config.mjs	Removes `swcMinify` and keeps MDX + security headers config.
lib/utils.ts	Formats `cn()` utility and imports.
lib/portfolio-data.ts	Normalizes portfolio content formatting/structure.
lib/constants.ts	Normalizes string literal + semicolon.
components/ui/text-morph.tsx	Formatting + minor string/JSX normalization.
components/ui/text-loop.tsx	Formatting + interval loop logic retained.
components/ui/text-effect.tsx	Formatting + minor refactors (unused-var handling).
components/ui/spotlight.tsx	Formatting + event listener wiring.
components/ui/scroll-progress.tsx	Formatting + minor options normalization.
components/ui/morphing-dialog.tsx	Formatting + dialog/focus handling code retained.
components/ui/magnetic.tsx	Formatting + effect dependency updates.
components/ui/animated-background.tsx	Improves typing around `Children.map`/`cloneElement` and formatting.
components/theme-toggle.tsx	Introduces a client theme toggle component.
app/skills/page.tsx	Formatting/wrapping updates.
app/sitemap.ts	Formatting/string normalization.
app/robots.ts	Formatting/string normalization.
app/projects/page.tsx	Formatting/wrapping updates.
app/page.tsx	Formatting + role rotator effect dependency fix.
app/open-source/page.tsx	Formatting/wrapping updates.
app/not-found.tsx	Formatting + HTML entity escaping for apostrophes.
app/layout.tsx	Metadata/viewport formatting and layout structuring updates.
app/globals.css	Moves Google Fonts `@import` and whitespace normalization.
app/experience/page.tsx	Formatting/wrapping updates.
app/contact/page.tsx	Formatting/wrapping updates and escaping for apostrophes.
app/components/tech-timeline.tsx	Formatting/wrapping updates.
app/components/navigation.tsx	Formatting/wrapping updates.
app/components/footer.tsx	Formatting/wrapping updates.
app/certifications/page.tsx	Formatting/wrapping updates.
app/blog/layout.tsx	Formatting + copy button logic retained.
app/blog/exploring-the-intersection-of-design-ai-and-design-engineering/page.mdx	Normalizes metadata + canonical wrapping; adds eslint-disable header.
app/blog/example-mdx-metadata/page.mdx	Normalizes metadata example formatting.
app/achievements/page.tsx	Formatting/wrapping updates.
app/about/page.tsx	Formatting/wrapping updates.
MAINTENANCE_GUIDE.md	Whitespace cleanup.
FINAL_OPTIMIZATION.md	Whitespace cleanup.
DELIVERY_SUMMARY.txt	Whitespace cleanup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-07T10:28:35Z

components/ui/morphing-dialog.tsx

@@ -217,25 +217,25 @@ function MorphingDialogContent({
    >


MorphingDialogTrigger sets aria-controls to motion-ui-morphing-dialog-content-${uniqueId}, but MorphingDialogContent doesn’t define a corresponding id on the dialog element. Add an id here to match aria-controls (or adjust/remove aria-controls) so assistive tech can correctly associate the trigger with the dialog.

Copilot · 2026-02-07T10:28:35Z

components/theme-toggle.tsx

+import { useTheme } from "next-themes";
+import { useEffect, useState } from "react";
+import { Moon, Sun } from "lucide-react";
+
+export function ThemeToggle() {
+  const { setTheme, theme } = useTheme();
+  const [mounted, setMounted] = useState(false);
+
+  useEffect(() => {
+    setMounted(true);
+  }, []);
+
+  if (!mounted) {
+    return (
+      <button
+        className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"
+        aria-label="Toggle theme"
+      >
+        <Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100 opacity-0" />
+      </button>
+    );
+  }
+
+  return (
+    <button
+      onClick={() => setTheme(theme === "dark" ? "light" : "dark")}
+      className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"
+      aria-label="Toggle theme"
+    >
+      {theme === "dark" ? (
+        <Moon className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />
+      ) : (
+        <Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />
+      )}
+    </button>
+  );
+}


This ThemeToggle component is introduced but there are no references to it anywhere in the codebase (so it won’t render). Either wire it into the UI (e.g., navigation/header) or remove it to avoid dead code.

Suggested change

import { useTheme } from "next-themes";

import { useEffect, useState } from "react";

import { Moon, Sun } from "lucide-react";

export function ThemeToggle() {

const { setTheme, theme } = useTheme();

const [mounted, setMounted] = useState(false);

useEffect(() => {

setMounted(true);

}, []);

if (!mounted) {

return (

<button

className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"

aria-label="Toggle theme"

>

<Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100 opacity-0" />

</button>

);

}

return (

<button

onClick={() => setTheme(theme === "dark" ? "light" : "dark")}

className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"

aria-label="Toggle theme"

>

{theme === "dark" ? (

<Moon className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />

) : (

<Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />

)}

</button>

);

}

// ThemeToggle component removed because it was not referenced anywhere in the codebase.

// This avoids keeping dead code around. Reintroduce and wire it into the UI if needed.

Copilot · 2026-02-07T10:28:35Z

app/globals.css

+@import url('https://fonts.googleapis.com/css2?family=JetBrains+Mono:wght@400;500;600;700&display=swap');
 @import 'tailwindcss';
+


globals.css imports JetBrains Mono from fonts.googleapis.com even though fonts are already configured via next/font/google in app/layout.tsx. This adds an extra external request (and can fail in locked-down environments, as noted in the PR). Prefer removing the CSS @import and relying on next/font for self-hosted fonts.

Copilot · 2026-02-07T10:28:35Z

components/theme-toggle.tsx

+      <button
+        className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"
+        aria-label="Toggle theme"
+      >
+        <Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100 opacity-0" />
+      </button>


These buttons omit an explicit type. If ThemeToggle is ever rendered inside a
, the default type="submit" can cause accidental form submissions. Set type="button" for both the mounted and fallback button renders.

Copilot · 2026-02-07T10:28:35Z

components/theme-toggle.tsx

+      onClick={() => setTheme(theme === "dark" ? "light" : "dark")}
+      className="rounded-full p-2 transition-colors hover:bg-zinc-100 dark:hover:bg-zinc-800"
+      aria-label="Toggle theme"
+    >
+      {theme === "dark" ? (
+        <Moon className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />
+      ) : (
+        <Sun className="h-5 w-5 text-zinc-900 dark:text-zinc-100" />
+      )}


next-themes theme can be "system" or temporarily undefined; using it directly for both the icon and toggle decision can lead to inconsistent UI. Prefer resolvedTheme for display and toggle logic, and handle the non-"dark"/"light" case explicitly.

Copilot · 2026-02-07T10:28:36Z

components/ui/spotlight.tsx

+    parentElement.addEventListener("mousemove", handleMouseMove);
+    parentElement.addEventListener("mouseenter", () => setIsHovered(true));
+    parentElement.addEventListener("mouseleave", () => setIsHovered(false));

    return () => {
-      parentElement.removeEventListener('mousemove', handleMouseMove)
-      parentElement.removeEventListener('mouseenter', () => setIsHovered(true))
-      parentElement.removeEventListener('mouseleave', () => setIsHovered(false))
-    }
-  }, [parentElement, handleMouseMove])
+      parentElement.removeEventListener("mousemove", handleMouseMove);
+      parentElement.removeEventListener("mouseenter", () => setIsHovered(true));
+      parentElement.removeEventListener("mouseleave", () =>
+        setIsHovered(false),
+      );


The mouseenter/mouseleave listeners are added with inline arrow functions but removed with new inline arrow functions, so the cleanup never removes the original listeners. This will leak listeners and can keep state updates firing after unmount. Store the handlers in stable variables (e.g., useCallback) and pass the same function references to both addEventListener and removeEventListener.

Copilot · 2026-02-07T10:28:36Z

components/ui/morphing-dialog.tsx

  return (
    <motion.div
      ref={triggerRef}
      layoutId={`dialog-${uniqueId}`}
-      className={cn('relative cursor-pointer', className)}
+      className={cn("relative cursor-pointer", className)}


The dialog trigger ref stored in context (used for focus restoration in MorphingDialogContent) is never attached to the actual trigger element—MorphingDialogTrigger uses its own optional triggerRef prop instead. This means triggerRef.current will remain null and focus restoration on close won’t work. Attach the context triggerRef to the trigger element (or merge the passed-in ref with the context ref).

Copilot · 2026-02-07T10:28:36Z

app/blog/layout.tsx

  useEffect(() => {
    setTimeout(() => {
-      setText('Copy')
-    }, 2000)
-  }, [text])
+      setText("Copy");
+    }, 2000);
+  }, [text]);


This effect sets a timeout on every text change but never clears the previous timeout. If the user clicks quickly after mount, an earlier timeout can overwrite "Copied" prematurely, and timeouts can run after unmount. Store the timeout id and clear it in the cleanup; also consider only scheduling the reset when text is "Copied".

Copilot · 2026-02-07T10:28:36Z

components/ui/text-loop.tsx

  useEffect(() => {
-    if (!trigger) return
+    if (!trigger) return;

-    const intervalMs = interval * 1000
+    const intervalMs = interval * 1000;
    const timer = setInterval(() => {
      setCurrentIndex((current) => {
-        const next = (current + 1) % items.length
-        onIndexChange?.(next)
-        return next
-      })
-    }, intervalMs)
-    return () => clearInterval(timer)
-  }, [items.length, interval, onIndexChange, trigger])
+        const next = (current + 1) % items.length;
+        onIndexChange?.(next);
+        return next;
+      });
+    }, intervalMs);


If children is an empty array, items.length is 0 and (current + 1) % items.length becomes NaN, which will break rendering (items[currentIndex]). Guard against items.length === 0 (and possibly skip the interval when length <= 1).

Initial plan

d12598b

Copilot AI assigned Copilot and RohanExploit Feb 6, 2026

Copilot started work on behalf of RohanExploit February 6, 2026 14:13 View session

vercel bot had a problem deploying to Preview February 6, 2026 14:14 Failure

chore: merge incoming branch updates

90310ad

Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>

vercel bot had a problem deploying to Preview February 6, 2026 14:23 Failure

fix: resolve lint issues and hook deps

86c91ee

Co-authored-by: RohanExploit <178623867+RohanExploit@users.noreply.github.com>

vercel bot deployed to Preview February 6, 2026 14:32 View deployment

Copilot AI changed the title ~~[WIP] Fix build and improve performance~~ Merge incoming theme/build updates and fix lint regressions Feb 6, 2026

Copilot AI requested a review from RohanExploit February 6, 2026 14:34

Copilot finished work on behalf of RohanExploit February 6, 2026 14:34

RohanExploit marked this pull request as ready for review February 7, 2026 10:24

Copilot AI review requested due to automatic review settings February 7, 2026 10:24

Copilot started reviewing on behalf of RohanExploit February 7, 2026 10:24 View session

Copilot AI reviewed Feb 7, 2026

View reviewed changes

RohanExploit approved these changes Apr 5, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge incoming theme/build updates and fix lint regressions#9

Merge incoming theme/build updates and fix lint regressions#9
Copilot wants to merge 3 commits intomainfrom
copilot/fix-build-improve-performance

Copilot AI commented Feb 6, 2026 •

edited

Loading

Uh oh!

vercel bot commented Feb 6, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Copilot AI Feb 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@import url('https://fonts.googleapis.com/css2?family=JetBrains+Mono:wght@400;500;600;700&display=swap');
		@import 'tailwindcss';

Conversation

Copilot AI commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

vercel bot commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 7, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 6, 2026 •

edited

Loading

vercel bot commented Feb 6, 2026 •

edited

Loading