⚡ Bolt: Bypass redundant bounding box check in spatial lookups#794
⚡ Bolt: Bypass redundant bounding box check in spatial lookups#794RohanExploit wants to merge 2 commits into
Conversation
…tial lookups This commit introduces a `pre_filtered` flag to `find_nearby_issues` in `backend/spatial_utils.py` and implements it in `backend/routers/issues.py` where spatial queries have already restricted the bounds of the issue objects. By skipping the local bounding box Python check when `pre_filtered` is enabled, redundant iterations over filtered data are bypassed, reducing cpu cycles in spatial deduplication checks. Furthermore, reading coordinate fields is fortified in `backend/spatial_utils.py` against dynamic typing edge cases resulting from SQL joins and optimizations by directly accessing `.latitude` and `.longitude`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for fixmybharat canceled.
|
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🙏 Thank you for your contribution, @RohanExploit!PR Details:
Quality Checklist:
Review Process:
Note: The maintainers will monitor code quality and ensure the overall project flow isn't broken. |
There was a problem hiding this comment.
Pull request overview
This PR optimizes spatial issue deduplication/lookup by introducing a pre_filtered flag to find_nearby_issues, allowing callers to skip redundant Python bounding-box checks when the candidate set has already been bounded by SQL filters.
Changes:
- Added
pre_filteredparameter tobackend/spatial_utils.py::find_nearby_issuesand gated bounding-box checks on it. - Updated
backend/routers/issues.pyto passpre_filtered=Truefor SQL-bounded nearby/deduplication queries. - Recorded the optimization rationale in
.jules/bolt.md.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| backend/spatial_utils.py | Adds pre_filtered to bypass local bounding-box checks and refactors distance-loop attribute access/math. |
| backend/routers/issues.py | Passes pre_filtered=True in SQL-bounded call sites; includes formatting/refactor touches in endpoints. |
| .jules/bolt.md | Documents the performance learning and action item for skipping redundant bounding-box checks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Optimization: pre-filter using a bounding box to avoid math on distant points | ||
| min_lat, max_lat, min_lon, max_lon = get_bounding_box(target_lat, target_lon, radius_meters) | ||
| min_lat, max_lat, min_lon, max_lon = get_bounding_box( | ||
| target_lat, target_lon, radius_meters | ||
| ) |
| def find_nearby_issues( | ||
| issues: List[Issue], | ||
| target_lat: float, | ||
| target_lon: float, | ||
| radius_meters: float = 50.0 | ||
| radius_meters: float = 50.0, |
| radius_meters: float = 50.0, | ||
| pre_filtered: bool = False, | ||
| ) -> List[Tuple[Issue, float]]: |
| ) | ||
| from fastapi.responses import JSONResponse | ||
| from fastapi.concurrency import run_in_threadpool | ||
| from sqlalchemy.orm import Session, defer |
| radius_meters: float = 50.0, | ||
| pre_filtered: bool = False, | ||
| ) -> List[Tuple[Issue, float]]: | ||
| """ | ||
| Find issues within a specified radius of a target location. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This commit removes the logging of potentially sensitive cache keys as clear text. Since cache keys can contain encoded personal information like emails or identifiable data, logging them violates security standards and triggers CodeQL analysis failures.
Description
Optimized spatial issue deduplication lookup functions by introducing a
pre_filteredflag, which skips redundant Python bounding-box logic when input data bounds are already filtered at the database level.Changes
pre_filteredparameter tobackend/spatial_utils.py->find_nearby_issues.backend/spatial_utils.pyto skip coordinate-bounds-checks ifpre_filteredis true.backend/routers/issues.pyto callfind_nearby_issueswithpre_filtered=Truewhere applicable..jules/bolt.md.PR created automatically by Jules for task 2314718657733116230 started by @RohanExploit
Summary by cubic
Skips redundant Python bounding-box checks in spatial lookups by adding a
pre_filteredflag, speeding up deduplication and the/issues/nearbyendpoint. Also removes sensitive cache key logging flagged by CodeQL.Refactors
pre_filteredtofind_nearby_issuesand call it withpre_filtered=Truewhere SQL already bounds results inissues.py.Nonechecks and a faster equirectangular path for short distances..jules/bolt.md.Bug Fixes
backend/cache.pyto avoid exposing sensitive data and satisfy CodeQL.Written for commit 5424673. Summary will update on new commits. Review in cubic