Skip to content

Don't nest inside placeholder selectors #77

@Jeremy-Walton

Description

@Jeremy-Walton

https://sass-lang.com/documentation/style-rules/placeholder-selectors

We are using placeholder selectors throughout our components, however, we are not gaining much from how we use them and they can potentially cause issues.

We have seen in tests running in selenium webdriver using the chrome driver that placeholder selectors in combination with nested classes and extends can cause odd behavior.

The main benefits from placeholder selectors seem to be composability and "atomic" structure. We tend to write styles using a BEM style where you have a base "Block" and then "modifiers" change things when added on. Therefore we always know a placeholder will be used so the benefit of it getting excluded from compile time is not really gained.

Metadata

Metadata

Assignees

No one assigned

    Labels

    CleanupClean up stylesbugSomething isn't working

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions