Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Nov 4, 2022

Task

#92

Why?

We need more semantic stops in the default theme. This will allow for more fine control over the look and feel.

What Changed

  • Update default primary color to RMS blue
  • Update luminosity scales
  • Update semantic scales
  • Clean up theming documentation
  • Remove the hover semantic style since we have better stops
  • Update token builder to point to correct names
  • Review Dark mode overrides with @scriswell

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Do you need to update the package version?

Screenshots

Here is the sidebar as a small sample of the color change.

Screen Shot 2022-11-03 at 9 06 09 PM

@Jeremy-Walton Jeremy-Walton added enhancement New feature or request Breaking Change This will cause problems so be sure to indicate that in the release notes labels Nov 4, 2022
@Jeremy-Walton Jeremy-Walton added this to the v0.1.1-beta Release milestone Nov 4, 2022
@Jeremy-Walton Jeremy-Walton self-assigned this Nov 4, 2022
@Jeremy-Walton Jeremy-Walton linked an issue Nov 4, 2022 that may be closed by this pull request
@scriswell
Copy link
Collaborator

Note: Remember to remove the --rm-color-[]-hover, and --rm-color-[]-on-hover tokens

@Jeremy-Walton Jeremy-Walton merged commit 1777f32 into main Nov 4, 2022
@Jeremy-Walton Jeremy-Walton deleted the ghi92-semantic-stops branch November 4, 2022 20:34
@Jeremy-Walton Jeremy-Walton added the Theme Tokens Changes to the theme tokens label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change This will cause problems so be sure to indicate that in the release notes enhancement New feature or request Theme Tokens Changes to the theme tokens

Development

Successfully merging this pull request may close these issues.

Add more semantic stops

3 participants