Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Dec 16, 2022

Why?

Experiment in implementing some linting rules for the project

What Changed

  • Add eslint for JS
  • Add stylelint for SCSS
  • Add prettier for formatting
  • Allow prettier to format css

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Do you need to update the package version?

@Jeremy-Walton Jeremy-Walton marked this pull request as ready for review December 16, 2022 16:48
Copy link
Collaborator

@scriswell scriswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jeremy-Walton Approved with notes/suggestions.

@Jeremy-Walton Jeremy-Walton added this to the v0.1.2-beta Release milestone Dec 16, 2022
@Jeremy-Walton Jeremy-Walton deleted the linting branch December 17, 2022 21:34
@Jeremy-Walton Jeremy-Walton added the Repository Change Changes to the repository that don't affect the package code label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Repository Change Changes to the repository that don't affect the package code

Development

Successfully merging this pull request may close these issues.

4 participants