Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

Task

#112

Why?

The Tom Select Addon that provides styling for tom select that matches our system seems to make too many assumptions and usually needs to be further styled when pulled into an app.

What Changed

  • Simplify overrides
  • Label overrides to make it easier to understand

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Do you need to update the package version?

Screenshots

Screenshot 2022-12-30 at 5 51 30 PM

Screenshot 2022-12-30 at 5 51 36 PM

Screenshot 2022-12-30 at 5 52 25 PM

@Jeremy-Walton Jeremy-Walton added Cleanup Clean up styles Breaking Change This will cause problems so be sure to indicate that in the release notes Simplification labels Dec 30, 2022
@Jeremy-Walton Jeremy-Walton added this to the v0.1.3-beta Release milestone Dec 30, 2022
@Jeremy-Walton Jeremy-Walton self-assigned this Dec 30, 2022
@Jeremy-Walton Jeremy-Walton linked an issue Dec 30, 2022 that may be closed by this pull request
@Jeremy-Walton Jeremy-Walton changed the base branch from main to refinement-release December 30, 2022 22:58
@Jeremy-Walton Jeremy-Walton force-pushed the ghi-112-tom-select-revisited branch 2 times, most recently from f4dfd35 to 8571e8b Compare January 6, 2023 21:06
@Jeremy-Walton Jeremy-Walton changed the base branch from refinement-release to main January 6, 2023 21:06
@Jeremy-Walton Jeremy-Walton force-pushed the ghi-112-tom-select-revisited branch from 8571e8b to ff4f35c Compare January 6, 2023 21:10
@Jeremy-Walton Jeremy-Walton force-pushed the ghi-112-tom-select-revisited branch from ff4f35c to e8d0ad4 Compare January 6, 2023 21:16
@Jeremy-Walton
Copy link
Member Author

Reviewed in Person with @scriswell . He gave 👍

@Jeremy-Walton Jeremy-Walton merged commit 8e3b49c into main Jan 6, 2023
@Jeremy-Walton Jeremy-Walton deleted the ghi-112-tom-select-revisited branch January 6, 2023 21:23
@Jeremy-Walton Jeremy-Walton added the Addons Changes to the addons label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Addons Changes to the addons Breaking Change This will cause problems so be sure to indicate that in the release notes Cleanup Clean up styles Simplification

Development

Successfully merging this pull request may close these issues.

Revisit Tom Select

2 participants