prevent form-error from shifting form-group [fix #138] #139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I pushed some commits to simplify the fix. It had to do with how it was handling the layout of the inner content of the grid. I use min-content for the rows instead of absolutely positioning and translating the error message. This also revealed an existing bug with Checkboxes and Radios where they were not laying out correctly. |
Jeremy-Walton
force-pushed
the
form-errors-cause-field-alignment-issues
branch
from
c777891 to
1bbc30a
Compare
Jeremy-Walton
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
see issue #138
Screenshots
CSS SubGrid would provide a much more elegant solution..
I can imagine a
.form-rowtaking over for.form-groupwith it's own grid area. So, given.form-row > .form-group*n > .form-label+.form-control+.form-erroreach label/control/error would occupy a grid-row with their respective siblings in neighboring.form-groups. Alas