Skip to content

Conversation

@Jeremy-Walton
Copy link
Member

@Jeremy-Walton Jeremy-Walton commented Aug 19, 2022

Task

#60

What Changed

  • Use correct token for icon line height
  • Use middle for icon vertical alignment so it lines up correctly when used with text.
  • Add documentation for icons

Sanity Check

  • Have you updated any usage of changed tokens?
  • Have you updated the docs with any component changes?
  • Do you need to update the package version?

Screenshots

Screen Shot 2022-08-19 at 4 43 18 PM

@Jeremy-Walton Jeremy-Walton self-assigned this Aug 19, 2022
@Jeremy-Walton Jeremy-Walton added bug Something isn't working documentation Improvements or additions to documentation labels Aug 19, 2022
@Jeremy-Walton Jeremy-Walton added this to the v0.0.8-beta Release milestone Aug 19, 2022
@Jeremy-Walton Jeremy-Walton linked an issue Aug 19, 2022 that may be closed by this pull request
@Jeremy-Walton Jeremy-Walton marked this pull request as ready for review August 21, 2022 19:56
@Jeremy-Walton Jeremy-Walton mentioned this pull request Aug 21, 2022
33 tasks
@Jeremy-Walton Jeremy-Walton force-pushed the ghi60-icon-sizing branch 2 times, most recently from 3330df8 to ad1b1aa Compare August 22, 2022 17:04
@Jeremy-Walton Jeremy-Walton merged commit 0dbb4cb into main Aug 22, 2022
@Jeremy-Walton Jeremy-Walton deleted the ghi60-icon-sizing branch August 22, 2022 19:21
@Jeremy-Walton Jeremy-Walton added the Components Changes to a component label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Components Changes to a component documentation Improvements or additions to documentation

Development

Successfully merging this pull request may close these issues.

Icon sizing issues

3 participants