[GHI #72] button icon with breakpoints #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeremy-Walton
force-pushed
the
ghi72-btn-icon-with-breakpoints
branch
from
439b508 to
8bc866c
Compare
scriswell
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
#72
Why?
Not only was the initial implementation of the small breakpoint size adjustment not handling
btn--iconcorrectly,It was accidentally removed in https://github.com/RoleModel/rolemodel-design-system/pull/80/files
This PR adds it back and fixes previous bugs
What Changed
Sanity Check
Have you updated any usage of changed tokens?Do you need to update the package version?Screenshots