Skip to content

Very urgent! AttackMaster v5.0.4 Fix critical error - parentheses on calculation #2138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

Very urgent! AttackMaster v5.0.4 Fix critical error - parentheses on calculation #2138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4021893
Fix critical error - parentheses on calculation
DameryDad Oct 8, 2025
560b3c0
Fix reference to reSaveSpecs
DameryDad Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions AttackMaster/5.0.4/attackMaster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
var reACSpecs;
var reThiefSpecs;
var reModSpecs;
var reSaveSpecs;
var spellLevels;
var classLevels;
var rangedWeapMods;
Expand Down Expand Up @@ -1002,6 +1003,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
reACSpecs = RPGMap.reACSpecs;
reThiefSpecs = RPGMap.reThiefSpecs;
reModSpecs = RPGMap.reModSpecs;
reSaveSpecs = RPGMap.reSaveSpecs;
DBindex = undefined;
flags.noWaitMsg = true;
setTimeout( () => {flags.noWaitMsg = false}, 5000 );
Expand Down Expand Up @@ -2910,7 +2912,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
adj = (parseInt(thisData.adj || 0) + (dmgType !== 'nadj' ? parseInt(thisData[dmgType] || 0) : 0)),
dexAdj = Math.floor(dexBonus * parseFloat(Math.max(thisData.dexBonus,0))),
curDexAdj = Math.floor(dexBonus * parseFloat(Math.max(curBest.data.dexBonus,0))),
acDiff = ((curBest.data.ac || 0) - (curBest.data.adj || 0) - (curDexAdj)*dexBonus)) - (ac - adj - dexAdj);
acDiff = ((curBest.data.ac || 0) - (curBest.data.adj || 0) - (curDexAdj*dexBonus)) - (ac - adj - dexAdj);
let diff;

switch (priority) {
Expand All @@ -2933,7 +2935,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
return diff;
};

const assessItem = function( itemName, itemTrueName, itemCharge, itemSpecs, itemData ) {
const assessItem = function( itemName, itemTrueName, itemCharge, itemSpecs, itemData ) { // reSaveSpecs

let ac, acData, acRules, isMod, data,
itemType, itemClass, itemHands, itemSuperType, itemAC, itemAdj, itemCursed, itemRules,
Expand Down
6 changes: 4 additions & 2 deletions AttackMaster/attackMaster.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -649,6 +649,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
var reACSpecs;
var reThiefSpecs;
var reModSpecs;
var reSaveSpecs;
var spellLevels;
var classLevels;
var rangedWeapMods;
Expand Down Expand Up @@ -1002,6 +1003,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
reACSpecs = RPGMap.reACSpecs;
reThiefSpecs = RPGMap.reThiefSpecs;
reModSpecs = RPGMap.reModSpecs;
reSaveSpecs = RPGMap.reSaveSpecs;
DBindex = undefined;
flags.noWaitMsg = true;
setTimeout( () => {flags.noWaitMsg = false}, 5000 );
Expand Down Expand Up @@ -2910,7 +2912,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
adj = (parseInt(thisData.adj || 0) + (dmgType !== 'nadj' ? parseInt(thisData[dmgType] || 0) : 0)),
dexAdj = Math.floor(dexBonus * parseFloat(Math.max(thisData.dexBonus,0))),
curDexAdj = Math.floor(dexBonus * parseFloat(Math.max(curBest.data.dexBonus,0))),
acDiff = ((curBest.data.ac || 0) - (curBest.data.adj || 0) - (curDexAdj)*dexBonus)) - (ac - adj - dexAdj);
acDiff = ((curBest.data.ac || 0) - (curBest.data.adj || 0) - (curDexAdj*dexBonus)) - (ac - adj - dexAdj);
let diff;

switch (priority) {
Expand All @@ -2933,7 +2935,7 @@ var attackMaster = (function() { // eslint-disable-line no-unused-vars
return diff;
};

const assessItem = function( itemName, itemTrueName, itemCharge, itemSpecs, itemData ) {
const assessItem = function( itemName, itemTrueName, itemCharge, itemSpecs, itemData ) { // reSaveSpecs

let ac, acData, acRules, isMod, data,
itemType, itemClass, itemHands, itemSuperType, itemAC, itemAdj, itemCursed, itemRules,
Expand Down
Loading