Lesson 8#4
Open
Rollen1337 wants to merge 2 commits into
Open
Conversation
feat: - ФАЙЛЫ С ДШКОЙ И ГНУЛИНУХ 7 УРОК
feat: 8.2.{1..6}
mdubakin
reviewed
Feb 17, 2023
mdubakin
left a comment
mdubakin
left a comment
There was a problem hiding this comment.
Молодец!
Обрати внимание на:
- Расширенные операторы присваивания.
- Нейминг переменных цикла
for, когда они не используются.
There was a problem hiding this comment.
iне используется- функции
range()лучше передать один аргумент10, чем 2 аргумента1и11
Suggested change
| for i in range(1, 11): | |
| for _ in range(10): |
Comment on lines
9
to
10
There was a problem hiding this comment.
Suggested change
| print(count) | |
| print(p) | |
| print(count, p, sep="\n") |
Comment on lines
10
to
11
There was a problem hiding this comment.
Suggested change
| print(s) | |
| print(mx) | |
| print(s, mx, sep="\n") |
There was a problem hiding this comment.
Suggested change
| product = product * digit | |
| product *= digit |
There was a problem hiding this comment.
Не забывай о расширенных операторах присваивания:
Suggested change
| n = n // 10 | |
| n //= 10 |
There was a problem hiding this comment.
Лишняя запятая :)
Suggested change
| a, b, = int(input()), int(input()) | |
| a, b = int(input()), int(input()) |
Comment on lines
12
to
13
There was a problem hiding this comment.
Suggested change
| print(count) | |
| print(maximum) | |
| print(count, maximum, sep="\n") |
Comment on lines
10
to
11
There was a problem hiding this comment.
Suggested change
| print(count) | |
| print(maximum) | |
| print(count, maximum, sep="\n") |
Comment on lines
25
to
30
There was a problem hiding this comment.
Suggested change
| print(count_digit_3) | |
| print(count_last_digit) | |
| print(count_even_digit) | |
| print(total_digit_higher_5) | |
| print(total_digit_higher_7) | |
| print(count_digit_0_5) | |
| print(count_digit_3, count_last_digit, count_even_digit, total_digit_higher_5, total_digit_higher_7, count_digit_0_5, sep="\n") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.