Some table view tweaks for demo #103
Conversation
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| ) | ||
|
|
||
| // This extra fetch is only until we have a real API | ||
| const { data: examples, isLoading: examplesIsLoading } = useGetList<any, any>( |
There was a problem hiding this comment.
If you wonder @mihow, seems Mockend is limited in a way that makes it tricky to handle nested objects. Had to put images in a separate collection -> separate API call. Not very nice, but should just be until we have the real API in place.
There was a problem hiding this comment.
Okay, thanks for the workaround. Hopefully we can switch the real UI soon!
|
|
||
| .content { | ||
| margin: 32px; | ||
| padding-left: 0px; |
There was a problem hiding this comment.
@annavik I tried tweaking this a bit myself to improve the layouts between 720 & 1024. I think my most common viewport on the desktop is about 980px.
| import React from 'react' | ||
| import styles from './gallery.module.scss' | ||
|
|
||
| export const Gallery = ({ |
There was a problem hiding this comment.
Should this be showing up in Storybook or does it need to be added manually?
There was a problem hiding this comment.
We would need to setup a small "stories" file for it, in order for it to show up. Felt a bit torn here, if the gallery view should be considered to be part of the design system or not, maybe it should? Right now, only the simple card component is.
Summary of changes:
Scroll is now part of the table:
Tables after update: