Deployment details + map component #152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
kimf
approved these changes
May 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
For the map we use React Leaflet (https://react-leaflet.js.org/) with OpenStreetMap (https://www.openstreetmap.org/) as a tile provider. In upcoming PR:s we will setup forms for creating and updating deployments, in this one we only show the details.
Screenshots:
Overview with deployment map. This map uses multiple markers and the markers are also interactive. On click we show deployment info and on deployment name click we go to details view. Default zoom and bounds are set based on marker positions.
Deployment details view. This marker is not interactive, we just use it to show the location.
Deployment details view with editable location. This marker is interactive. On drag, latitude and longitude fields are updated and also the other way around (if fields are updated, the marker is updated). We also update map bounds on location change. This view can only be triggered from code for now.
