Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Jun 29, 2023

In this PR we setup interface for jobs and job details (using dummy data until BE is ready). We are still missing interface for setting up a new job, but this PR started to get huge! As part of these changes, we are also removing the previous "Batch ID" page.

Screenshots

Some of the new generic UI components that was added as part of creating the UI:
Screenshot 2023-06-29 at 16 16 30

Screenshot 2023-06-29 at 16 24 39

Table for jobs:
Screenshot 2023-06-29 at 16 17 44

Job details:
Screenshot 2023-06-29 at 16 17 44

Screenshot 2023-06-29 at 16 17 35

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 4359908
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/649e2755d1773800084cf392
😎 Deploy Preview https://deploy-preview-177--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 29, 2023

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 4359908
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/649e2755383a3800087f4a34
😎 Deploy Preview https://deploy-preview-177--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow
Copy link
Collaborator

mihow commented Jun 30, 2023

Wow! This was a big one. Really cool though. I love seeing the different type of status indicators in different stages and UI contexts. I am glad we have both the vertical and horizontal wizards to help break up complexity of our multi-step processes.

The one thing I changed is the display text for the Jobs menu item. Even though we are creating & listing Job objects, I still like "Batch ID" for the section title. But I am open to debate that with the team!

@mihow mihow self-requested a review June 30, 2023 00:56
@annavik
Copy link
Member Author

annavik commented Jun 30, 2023

Wow! This was a big one. Really cool though. I love seeing the different type of status indicators in different stages and UI contexts. I am glad we have both the vertical and horizontal wizards to help break up complexity of our multi-step processes.

The one thing I changed is the display text for the Jobs menu item. Even though we are creating & listing Job objects, I still like "Batch ID" for the section title. But I am open to debate that with the team!

Ah yes, let's change that for now and revisit if the team disagrees! :)

@annavik annavik merged commit 91ec8bc into main Jun 30, 2023
@mihow mihow deleted the web-ui-jobs branch August 14, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants