Link to a specific capture in session detail view #195
Conversation
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annavik
changed the title
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| return { | ||
| id, | ||
| captureId: | ||
| detection.capture !== undefined ? `${detection.capture}` : undefined, |
There was a problem hiding this comment.
If you want to add capture id to occurrence detections using a different key or something, this is where we need to change how to access it @mihow
|
@annavik great call with using capture.id to target frames instead of dectection.id, that's much more direct and reliable! I made the changes you suggested to make that possible:
Now the linking from detection thumb to the session detail is much more satisfying. You can click on the last thumb and it will actually go to the last frame (and still select the right occurrence). 
One small todo (for later) would be to scroll down to the right detection when you navigate from the capture view to the occurrence detail modal. Also the back button wasn't working for me at one point, but now it is! So maybe something to look out for. |
Adding support for links to a specific capture in session detail view. I thought selections based on capture here was a nice approach (instead of using detections) because it also fits with how we present selections in UI.
If both occurrence and capture are part of the URL, the capture will be prioritised for the first selected capture (I think BE is not doing the same for the offset, but I think maybe it should?).
Example links:
Also preparing detections in occurrence details to link to a specific capture in session details with that occurrence selected. We don't have this info atm, but I hope for it to work if you just add the capture here @mihow: