Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Aug 1, 2023

In this PR:

  • Add top bar with AMI logo.
  • Prepare info pages. To keep things simple for now, I suggest we use dialogs for this. For now we are using hard coded data in FE app. Happy to change this to a BE call once the endpoint is available :) Updated to use API!

Screenshots:

Screenshot 2023-08-02 at 11 33 16 Screenshot 2023-08-02 at 11 33 30

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 413a358
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/64ca221f32f4f700081710d0
😎 Deploy Preview https://deploy-preview-200--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 1, 2023

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 413a358
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/64ca221fe18e7100089dbd90
😎 Deploy Preview https://deploy-preview-200--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

padding: 24px 32px;
color: $color-neutral-800;

h1 {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some simple styling of HTML elements, let me know if we need more and we can easily extend. The app global styles are a bit limited since we are using CSS modules (making each component define its own styles, rather than using global CSS).

@annavik annavik marked this pull request as ready for review August 1, 2023 20:04
@mihow
Copy link
Collaborator

mihow commented Aug 1, 2023

Okay I merged the pages endpoints and they are available now!

https://api.dev.insectai.org/api/v2/pages/
https://api.dev.insectai.org/api/v2/pages/about/
https://api.dev.insectai.org/api/v2/pages/help/

Just a couple things if you have any more time:

  • Can we use the version of the logo that isn't perfectly square? This one has the little bird on the right cut off. Or is it a limitation of the styles? I think you used the full one for the favicon app icons. But I attached what I have here as well.
  • Can we update the URL routes for the pages? So /about & /help work?

Otherwise the styles look just fine! This is so great. Thank you thank you thank you.

Sticker mule cut line
AMI Logo
AMI logo traced

@annavik
Copy link
Member Author

annavik commented Aug 2, 2023

Okay I merged the pages endpoints and they are available now!

https://api.dev.insectai.org/api/v2/pages/ https://api.dev.insectai.org/api/v2/pages/about/ https://api.dev.insectai.org/api/v2/pages/help/

Just a couple things if you have any more time:

  • Can we use the version of the logo that isn't perfectly square? This one has the little bird on the right cut off. Or is it a limitation of the styles? I think you used the full one for the favicon app icons. But I attached what I have here as well.
  • Can we update the URL routes for the pages? So /about & /help work?

Otherwise the styles look just fine! This is so great. Thank you thank you thank you.

Sticker mule cut line AMI Logo AMI logo traced

  • Updated to use API data!
  • Good call about the logo, I changed it. Just remembered I added a "Logo material" tab in Figma before, with all the different versions I used for favicons. Makes it easy to adjust export size and format, depending on what you need.
  • Regarding routing, can we do it in a follow up PR? I think I would like to give the routing some more thought since the info pages are dynamic and also because the info dialogs can be triggered from anywhere in app.

@annavik annavik changed the title [WIP] Add logo and info pages Add logo and info pages Aug 3, 2023
@annavik annavik requested a review from mihow August 3, 2023 06:41
@mihow mihow merged commit 63f8852 into main Aug 3, 2023
@annavik annavik deleted the web-ui-logo-and-about branch October 11, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants