Add unit tests for auth related code #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-storybook canceled.
|
✅ Deploy Preview for ami-web canceled.
|
Member
Author
|
@mihow if we want to add to CI pipeline, this is what I think we should run: |
install pre-commit with: ``` brew install pre-commit pre-commit install ``` Or other options here: https://pre-commit.com/
Collaborator
|
I added the linting & tests to the github workflows and split up the frontend & backend tests so you don't have to wait for django stuff on every frontend change. I also added a pre-commit hook for the ESlint checks so you can catch linting errors before you commit them. Installation instructions here if you don't use it already! https://pre-commit.com/ @annavik feel free to update the github workflows as well, I am pretty new to them. |
mihow
approved these changes
Sep 12, 2023
Collaborator
mihow
left a comment
mihow
left a comment
There was a problem hiding this comment.
Thanks for so many tests! I think this will help us sleep at night and help us dev without fear!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
Also did some small lint tweaks, so that we can start include scripts for both (frontend) lint and test in pipelines, if we want?
As part of this PR, we also include 2 new libs:
Choice of method and libs is inspired by React Query docs.