Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Oct 3, 2023

Fixing small bug in header where "About" and "Help" were not possible to click. Related to click event not being passed from button component, which caused a dialog error.

@annavik annavik requested a review from mihow October 3, 2023 13:40
@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 3ee6532
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/651c19b5a713ef0008b77461
😎 Deploy Preview https://deploy-preview-267--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 50
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 3, 2023

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 3ee6532
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/651c19b5c9abc40007d13da7
😎 Deploy Preview https://deploy-preview-267--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@mihow mihow merged commit 0edbad9 into main Oct 3, 2023
@annavik annavik deleted the web-ui-fix-header-bug branch October 11, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants