Setup (more) generic form helpers #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mihow
requested changes
Oct 5, 2023
Collaborator
mihow
left a comment
mihow
left a comment
There was a problem hiding this comment.
Awesome! It looks seamless, except for I am unable to open the dialog for "register new deployment"
Uncaught TypeError: Cannot read properties of undefined (reading 'defaultPrevented')
Member
Author
Oops! I had forgot to sync with main where I fixed this Also added some new form stuff for delete, in that case we probably want to have a complete form to reuse |
mihow
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have some form helpers from before (see
FormControllerandFormField), but in this PR we will also setup some help components to handle form layout. Also we setup a hookuseFormErrorto streamline error handling further.As part of this PR we are also updating current forms to use these new helpers. In the next one, we will create som new forms for projects. Curious to see if we can do that without adding a lot of code, thanks to this.