Skip to content

Fix ordering in API #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mihow merged 4 commits into from
Oct 31, 2023
Merged

Fix ordering in API #296

mihow merged 4 commits into from
Oct 31, 2023

Conversation

@mihow
Copy link
Collaborator

@mihow mihow commented Oct 31, 2023 •
edited
Loading

  • Fix availability of all sort filters by changing base settings
  • Allow sorting events and occurrences by start time, duration and all other visible columns

@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit c7693be
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6540823e9f429e0008141f12
😎 Deploy Preview https://deploy-preview-296--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 31, 2023 •
edited
Loading

✅ Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit c7693be
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6540823e0f09ce0008e3f7f7
😎 Deploy Preview https://deploy-preview-296--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 51
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow requested a review from annavik October 31, 2023 04:28
@mihow mihow mentioned this pull request Oct 31, 2023
Closed
@mihow mihow merged commit 0e449bc into main Oct 31, 2023
@mihow mihow deleted the fix/ordering branch October 31, 2023 05:00
mihow added a commit that referenced this pull request Nov 2, 2023
@mihow
Fix ordering in API and add additional sort columns (#296)
6354f37 
* Fix filters and ordering

* Allow sorting by duration and start time

* Add sorting for all occurrence columns

* Add sorting for all Event columns
mihow added a commit that referenced this pull request Nov 2, 2023
@mihow
Fix ordering in API and add additional sort columns (#296)
33fcd4b 
* Fix filters and ordering

* Allow sorting by duration and start time

* Add sorting for all occurrence columns

* Add sorting for all Event columns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annavik annavik Awaiting requested review from annavik

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mihow