Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Nov 13, 2023

Fixes #309.

Summary of changes:

  • Add pipelines collection to project overview
  • Setup detail view for pipelines, including stages
  • Update job details to show stages params (semi related...)
  • Add pipeline picker to session details
  • Add capture details popover

Screenshots:

Screenshot 2023-11-13 at 17 33 54 Screenshot 2023-11-13 at 17 34 20 Screenshot 2023-11-13 at 17 34 26 Screenshot 2023-11-22 at 16 10 40 Screenshot 2023-11-22 at 16 08 35

@netlify
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit d16f201
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/655e18befd97aa0008766b6e
😎 Deploy Preview https://deploy-preview-315--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit d16f201
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/655e18be9f5e8b00086c75ad
😎 Deploy Preview https://deploy-preview-315--ami-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84
Accessibility: 100
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@annavik
Copy link
Member Author

annavik commented Nov 13, 2023

@mihow what do you think about using 2 rows for the controls? Felt easier to scale the UI this way

Screenshot 2023-11-13 at 17 49 40

@mihow
Copy link
Collaborator

mihow commented Nov 13, 2023

Rather than showing the pipeline name in the select component, what if it always just says "Pipeline" and when you open it, it has a checkmark next to the selected name. Or I do like the short name as well. We can use it in URLs too. For now, maybe use the ID, then I can swap the fields later.

I like the 2 lines for the controls.

Also, in the designs there is a control button for filters. What if we hide all controls until you click that? Then maybe we don't have to be so clever in fitting it all in.

image

@annavik
Copy link
Member Author

annavik commented Nov 22, 2023

Updated this PR with some new stuff:

  • Make it possible to expand/collapse detailed controls (also we will not fetch capture details and list of pipelines until detailed controls are expanded)
  • Show capture details in popover
  • Require pipeline to be set before capture can be processed (do we want this?)
  • Pass pipeline id when job is created from session details
  • Make it possible to see detailed controls while list of captures is loading (for example when changing score threshold)

PR desc is updated with some screenshots!

@annavik annavik marked this pull request as ready for review November 22, 2023 15:18
@mihow
Copy link
Collaborator

mihow commented Nov 23, 2023

Thank you for adding the stage details to the jobs panel. I'm already using it for new stages!

image

@mihow
Copy link
Collaborator

mihow commented Nov 23, 2023

Can you link the pipeline name to the pipeline details modal?

@mihow mihow merged commit 64217b5 into main Nov 23, 2023
@mihow mihow deleted the web-ui-pipelines branch February 8, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add table for ML models & pipelines

3 participants