Skip to content

Conversation

@mihow
Copy link
Collaborator

@mihow mihow commented Apr 12, 2024

image

image

Description TBD!

@netlify
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 9ace9c8
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6620aad8193ef300086c722f
😎 Deploy Preview https://deploy-preview-375--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 69
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 12, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 9ace9c8
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6620aad84ae84a000883cd3f
😎 Deploy Preview https://deploy-preview-375--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mihow mihow marked this pull request as ready for review April 16, 2024 03:28
@mihow mihow requested a review from annavik April 16, 2024 03:28
@mihow
Copy link
Collaborator Author

mihow commented Apr 16, 2024

Hi @annavik! This started as a "simple" change so users can make and populate Collections in the UI, since that is a missing piece for the batch processing workflow. But it turned out to be my largest contribution to the UI code yet! And I had a lot of catching up to do. I know this could be cleaner, but I am hoping to compromise and make something available to demo soon. We should probably discuss more about collections. They may be outgrowing the sub-tab under project overview.

After this, I am definitely look forward to re-using the backend types in the frontend. I tested that using our autogenerated openAPI schema -> typscript and it worked amazingly well. I will make a PR with an example soon. Also I am curious about using react-hook-form library more directly. It seems like there are some layers of abstraction/simplification that could be skipped? It was difficult for me to find where values are being transformed before being passed to the server. Anyway, take a look if you have a chance, but no worries if we have to wait until June.

@mihow mihow changed the title AMI-267-Enable-Collections-to-be-defined-populated-from-UI [AMI-267] Enable collections to be defined & populated from UI Apr 17, 2024
Copy link
Collaborator Author

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it! This also fixes an issue where the edit forms appear for non-logged in users

@mihow mihow merged commit 9254fd0 into main Apr 19, 2024
@mihow mihow deleted the AMI-267-Enable-Collections-to-be-defined-populated-from-UI branch April 19, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants