Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Jun 3, 2024

Fixes #393 and #372

Summary:

  • Give number links a bubble style
  • Give regular links font weight medium
  • Tweak table row background color (to match the updated design)

@netlify
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 5ce3283
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/665dd7dd2ab985000890df28
😎 Deploy Preview https://deploy-preview-394--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 74
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 3, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 5ce3283
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/665dd7ddbaad0c00072d64c0
😎 Deploy Preview https://deploy-preview-394--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

export const columns: (projectId: string) => TableColumn<Session>[] = (
projectId: string
) => [
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes here are mostly because this file was missing some formatting (specified by Prettier).

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and very satisfying!

@mihow mihow merged commit a65ac19 into main Jun 4, 2024
@mihow mihow deleted the improvement/visible-table-links branch June 4, 2024 17:02
@mihow
Copy link
Collaborator

mihow commented Jun 4, 2024

Thanks for finding the duplicate ticket #372 ! I swear I had made one but couldn't find it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make filter links more visible

3 participants