Some improvements to table columns (occurrence and species) #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
Author
|
Let me know what you want to do this with @mihow. I'm fine with reverting moving verification status to score column if you feel we should do some more thinking here and we can just keep the 3 other tweaks :) |
mihow
approved these changes
Jun 18, 2024
mihow
approved these changes
Jun 18, 2024
Collaborator
|
After merging I noticed that we could add the same score component to the Species table as well! 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks to species and occurrence table after feedback from Lars! Also including some related tweaks. See the changes in this PR as a suggestion! :)
Summary of changes
Notes
In order to show the correct "agreed" status in table view, user info details has also been made globally available from a context as part of this PR. This makes it possible for us to easily access user info from any component in app, without having to refetch it. This behaviour can in general also be achieved by react query cache, but for user info I think it makes sense to put it in a context. This hook has some special auth behaviour I don't want to mess with.
Screenshots
Before:
After: