Skip to content

Conversation

@annavik
Copy link
Member

@annavik annavik commented Jul 2, 2024

Summary of changes

  • Show applied filters directly in page header in same styles as bubble links
  • Skip filter settings popover for now

Future plans for filters

  • Return filters in a more readable format from backend (so that we can show a label instead of ID in UI)
  • Add custom filter controls

Screenshots

Before:
Skärmavbild 2024-07-02 kl  10 44 33

After:
Skärmavbild 2024-07-02 kl  10 43 43

@annavik annavik added enhancement New feature or request frontend labels Jul 2, 2024
@annavik annavik added this to the Internal Beta V2 Release milestone Jul 2, 2024
@annavik annavik requested a review from mihow July 2, 2024 08:45
@annavik annavik self-assigned this Jul 2, 2024
@netlify
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for ami-web ready!

Name Link
🔨 Latest commit 34cd723
🔍 Latest deploy log https://app.netlify.com/sites/ami-web/deploys/6683be305ccfd00008efc579
😎 Deploy Preview https://deploy-preview-448--ami-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 71
Accessibility: 95
Best Practices: 92
SEO: 92
PWA: 70
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 2, 2024

Deploy Preview for ami-storybook ready!

Name Link
🔨 Latest commit 34cd723
🔍 Latest deploy log https://app.netlify.com/sites/ami-storybook/deploys/6683be301d9aa80008bc1804
😎 Deploy Preview https://deploy-preview-448--ami-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@mihow mihow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool! I added a ticket for me to add more details about the active filters in the API response #452

@mihow mihow merged commit 8df5a86 into main Jul 3, 2024
@mihow mihow deleted the improvement/visible-filters branch July 3, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants