Skip to content

Conversation

@mihow
Copy link
Collaborator

@mihow mihow commented Feb 6, 2025

Fixes #718

The main culprit was the pipelines in our registry have algorithms registered that are no longer being used by the actual pipeline in the ML Backend. So new images never get classifications from these old algorithms, but the images_filter always thinks they need classifications from those algorithms! And sends them back for processing.

This PR however adds some cleanup, logging & tests to help clarify what's going on. The main fix is a data entry clean up in the live DB.

@mihow mihow self-assigned this Feb 6, 2025
@sentry
Copy link

sentry bot commented Feb 6, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: ami/ml/models/pipeline.py

Function Unhandled Issue
collect_images ValueError: Must specify a collection, deployment or a list of images a...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@netlify
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for antenna-preview canceled.

Name Link
🔨 Latest commit b29ee74
🔍 Latest deploy log https://app.netlify.com/sites/antenna-preview/deploys/67d4f3a61f23000008f18f7a

@mihow mihow changed the title Fix/reprocessing existing results Fix reprocessing of existing results Mar 7, 2025
@mihow
Copy link
Collaborator Author

mihow commented Mar 14, 2025

The remaining image count works when using the same detector and binary classifier but not the species classifier

@mihow mihow marked this pull request as ready for review March 15, 2025 03:25
@mihow mihow merged commit 941f0f7 into main Mar 15, 2025
6 checks passed
@mihow mihow deleted the fix/reprocessing-existing-results branch March 15, 2025 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: Fix unnecessary reprocessing of all images

2 participants