-
Notifications
You must be signed in to change notification settings - Fork 11
Fix reprocessing of existing results #719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: ami/ml/models/pipeline.py
Did you find this useful? React with a 👍 or 👎 |
✅ Deploy Preview for antenna-preview canceled.
|
…ssing-existing-results
Collaborator
Author
|
The remaining image count works when using the same detector and binary classifier but not the species classifier |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718
The main culprit was the pipelines in our registry have algorithms registered that are no longer being used by the actual pipeline in the ML Backend. So new images never get classifications from these old algorithms, but the images_filter always thinks they need classifications from those algorithms! And sends them back for processing.
This PR however adds some cleanup, logging & tests to help clarify what's going on. The main fix is a data entry clean up in the live DB.