-
Notifications
You must be signed in to change notification settings - Fork 11
Update UI for identifications and show multiple suggestions per classification #741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for antenna-preview canceled.
|
|
@mihow I did notice that if I try to fetch classification details, I get 500-responses from the backend in some cases. This is how we present such a failure in UI: On localhost, this is the case for the initial occurrences I get, if I spin up a new database. If I process captures, the occurrences that will be generated can be expanded without any problems. Is this something to worry about? Maybe it's just the dummy database that needs to be updated, or would this affect all older classifications? |
Thanks, yes it shouldn't throw a 500 error if there are not top N choices. I will look into that. |
|
I found some cases where there is top-n data but the species values are |
|
@annavik Will you fix the merge conflicts while we wait for me to fix the backend issue? |
d2e5404 to
8c54374
Compare
Done! I have synced this with main and included some final tweaks as well. I think this one is ready now! This is how it looks if we get some error: This is how it looks if we get a response, but we have nothing to show: |
|
@mihow todo: only return the full list of logits & scores when requests explicitly by the user (query param or another view) |
This would be good to fix of course (as we talked about before), however even if we would get the full list, the frontend will now slice it to 5 items max. |
bf06eda to
280416f
Compare
|
This one is synced with main now! I have also added a few last tweaks:
|
mihow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested on staging and it's working quite well! This feature is a big deal. Sorry I put the breaks on merging for so long. Thank you for keeping the branch up-to-date. The new styles look great too!






Summary
In this PR we implement the new design for identifications. This includes showing multiple suggestions per classificatoins.
List of Changes
Related Issues
Detailed Description
We have going a bit back and forth around these changes. The initial design (see Figma) suggested separating "confirming identifications" from "custom identifications" and also a grouped structure. We did like these ideas, however they would mean some significant logic changes, which we decided we are not fully ready for. We have a few stakeholders that needs to be involved in such decisions, some active labeling projects to consider and also some more high prio tasks. Also, our most urgent need for identifications was to present machine predictions in a more detailed way. Therefore, we decided to skip the suggested logic updates on the backend side, focus on our most urgent needs, but still try use as much as possible from the updated design, with some compromises.
How to Test the Changes
Please test all features related to identifications:
Screenshots
Before:
After:
Deployment Notes
This PR needs a small update after the permission PR (see #693) is merged!