Add page "Code of conduct" to UI #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
annavik
commented
Mar 12, 2025
| </div> | ||
| ) | ||
| } | ||
| export const TermsOfServicePage = () => ( |
Member
Author
There was a problem hiding this comment.
Extracted code from this component to the shared component InfoPage
annavik
commented
Mar 12, 2025
| <Route path="collections/:id" element={<CollectionDetails />} /> | ||
| <Route path="*" element={<UnderConstruction />} /> | ||
| </Route> | ||
| <Route path="/:slug" element={<InfoPageContainer />} /> |
Member
Author
There was a problem hiding this comment.
We will no longer try to render an info page for generic slugs. This is a left over from when the backend returned dynamic content here.
Now we require exact matches!
annavik
changed the title
mihow
approved these changes
Mar 13, 2025
Collaborator
mihow
left a comment
mihow
left a comment
There was a problem hiding this comment.
Awesome this is a milestone! Perhaps there will be a reason to bring back dynamic pages in the future, but the addition of the 404 page and the fast response for bad paths is much better!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we include our new page "Code of conduct" in Antenna. The page is setup in a similar way as the page "Terms of service". We use same style and structure.
The content for this new page can be edited from a markdown file, see
ui/src/components/info-page/code-of-conduct-page/code-of-conduct.md.Since I modified our routing a bit as part of this PR, I also included a simple 404 page in this PR. We were missing that! For now, we use it if the current route can't be matched to a page.
Screenshots