-
Notifications
You must be signed in to change notification settings - Fork 11
New section for algorithms and category maps #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New section for algorithms and category maps #785
Conversation
✅ Deploy Preview for antenna-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This is looking great Vanessa! FYI, Anna just merged a big change to the project overview change. So make sure to bring this branch up-to-date with |
|
Thanks for the feedback @annavik ! I made some of the changes, a few I had some questions about:
I added this new section to the algorithm details called "Category Map Details." What do you think about this? I'm currently using a
Yes I think that would be good, but main concern here is it might get long -- I added it to test so let me know what you think.
Updated, hopefully I didn't miss any, will keep this in mind in future
I'm not sure how to solve this bug, I used the same component structure as the pipelines so I'm not sure why this is happening. Could we sync up on this?
Yes, is there a standard way/best practice I should be following for adding custom styling to components? In particular, this is the component that would need to be styled
I agree, I think it's probably best to go over this in a call. I'll ping you! |
|
TODOs
talk with michael about this |
|
Some notes from discussion with Anna:
|
Here is a code snipped for how to style an external HTML link as an icon button: |
Let me know if there's anywhere I can add this -- I was thinking inside the Algorithms list in "Pipeline Details" but the table component doesn't allow customizing links inside the columns
What's the best way to retrieve number of species? For example, if I visit a category map API endpoint, do I just count the number of labels? Or the number of data elements? http://localhost:8000/api/v2/ml/labels/11/
This might be a backend bug, but all of the fields (Except updated at and sorted at) cannot be sorted Aside: I can address all these points in a follow up PR since they might require more planning/investigating |
|
Thanks for the updates Vanessa! Here is a short summary of what I would like to do when we meet:
After this I think we can merge! :) Remaining items would be:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these new views! 🥳 From my side, I think we can merge this!
9df1860 to
dfa0ea6
Compare
|
Thanks so much for bringing this over the finish line @vanessavmac and @annavik! I went ahead and added the category counts and sortable fields! The category count was a slightly new challenge since we are using a special Postgres ArrayField, but it works quite well now and is fast. |
Hmm this is still working for me, we did update the UI kit lib component with a new prop here, maybe you need to rebuild your container if your are testing locally? Screen.Recording.2025-04-11.at.08.50.35.mov |
Thanks Michael! It's great to see the count 🙌 For the sorting I just pushed some small tweaks to streamline default order, etc. |
|
Also I added a few updates to processing services and pipeline views, to keep behavior consistent with links and things, even if not fully related to this PR. Ok I think that was the last polish! |
|
Thank you @annavik! I still couldn't get the link to work after running |











Summary
Add a new algorithms overview. Allow users to view the algorithm URI from the identification summary.
Related Issues
Closes #683
Screenshots
Algorithm details and overview




Pipeline links to algorithms
Identification summary links to algorithm