Make session info optional for occurrences #794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for antenna-preview canceled.
|
Collaborator
|
Thanks for jumping on this! Now I was able to update all Occurrence queries to be consistent and make our counts match!
|
mihow
reviewed
Apr 3, 2025
| class OccurrenceQuerySet(models.QuerySet): | ||
| def with_detections_count(self) -> models.QuerySet: | ||
| class OccurrenceQuerySet(models.QuerySet["Occurrence"]): | ||
| def valid(self): |
Collaborator
There was a problem hiding this comment.
@mohamedelabbas1996 I introduced a new queryset method called valid(). Let's begin adding this method to all models and use it in place of all(). We could override all() however this makes is almost impossible to debug or troubleshoot strange instances since you will never see them, even in the Django admin.
mihow
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this PR we make session info optional for occurrences. See #791 for background.
Screenshots
After the fix, we will display occurrences without a session like this. Also any links to session details are disabled. See https://deploy-preview-794--antenna-preview.netlify.app/projects/84/occurrences/125214 for live example.