Add missing custom permissions for test storage and sync deployment actions #932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sync deployment to project managers
✅ Deploy Preview for antenna-preview canceled.
|
annavik
approved these changes
Sep 3, 2025
Member
annavik
left a comment
annavik
left a comment
There was a problem hiding this comment.
Thanks @mohamedelabbas1996!
I tested the changes as a project manager (not an admin). It worked well for me!
- Before the updates I could not test the storage connection or sync captures ❌
- After the changes I could both test the storage and connection and sync captures ✅
I suggest we merge and deploy this to unblock users and create follow up tickets for other improvements related to this.
mihow
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing custom permissions for project managers to run test storage and sync deployment actions.
List of Changes
ami/main/models.pyto include missing custom permissions.ami/users/roles.pyto grant project managers access to these actions.0070_alter_project_options.py.Related Issues
Closes #931
Detailed Description
In PR #891, certain custom permissions were not included for project managers. As a result, users with the project manager role were denied access when attempting to run
syncdeployment orteststorage. This PR resolves the issue by adding the missing custom permissions forsyncandtestactions to project managers, ensuring they can perform these actions as expected.How to Test the Changes
teststorage action can be executed without a 403 Forbidden error.syncdeployment action can be executed successfully.Screenshots
N/A
Deployment Notes
The new permissions will be automatically added to existing users with the Project Manager role after the migrations are run by the "Create roles" function that is triggered by the post-migration signal.
Checklist