Settings page and layout tweaks #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ami-storybook ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for ami-web ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
annavik
changed the title
mihow
approved these changes
Mar 23, 2023
Collaborator
mihow
left a comment
mihow
left a comment
There was a problem hiding this comment.
Great stuff! Thanks for the well documented PR!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
In this PR we setup a settings dialog (still not posting any data though). This setup also includes some new UI components:
Also, we tweak the layout to fit screens of any size better. For example, we adjust the padding in some places and for the settings dialog we change width and number of columns depending on the screen size.
Screenshots
New UI components:
Dialog:
Text input:
Number input:
Select:
Slider:
Settings dialog with different screen sizes:
On a large screen (> 1024px):
On a medium screen (<= 1024px && > 720px)
On a small screen (<= 720px)
