Refactor API utilities and improve error handling and pagination#7
Merged
Conversation
- Split ballchasing/util.py into a subpackage: dates, iterators, replays, stats - Re-export all util functions from __init__.py - Add prefetching pagination via ThreadPoolExecutor in _iterable_from_request - Add deduplicate option to get_replays (by ID keys and date overlap) - Add ensure_sorted and mix_replay_iterators utilities - Change get_group_tree to yield (path_list, replay) tuples - Update typed definitions and constants - Move get_maps.py into scripts/ - Bump version in pyproject.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor util into subpackage and improve API iteration