Potential fix for code scanning alert no. 2: Workflow does not contain permissions#683
Merged
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
|
coverage: 100.0%. remained the same — alert-autofix-2 into main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/RomiC/ya-disk/security/code-scanning/2
Add an explicit
permissionsblock at the workflow root (top-level, alongsidenameandon) so it applies to all jobs unless overridden. For this workflow, the minimal safe baseline is:contents: read(needed byactions/checkout)pull-requests: read(safe for PR-context metadata access; does not grant write)This addresses CodeQL’s complaint without changing job logic or execution flow.
Edit only
.github/workflows/npm-test.yml, inserting the block after the trigger section (on) and beforejobs.Suggested fixes powered by Copilot Autofix. Review carefully before merging.