Skip to content

Add remaining services#181

Merged
RonanB96 merged 7 commits intomainfrom
remaining_services
Apr 3, 2026
Merged

Add remaining services#181
RonanB96 merged 7 commits intomainfrom
remaining_services

Conversation

@RonanB96
Copy link
Copy Markdown
Owner

@RonanB96 RonanB96 commented Mar 27, 2026

This pull request makes significant improvements to project documentation and enforces architectural and implementation rules for the Bluetooth SIG Standards Library. The changes clarify project structure, update and reorganize instructions for contributors, correct minor code issues, and update the Bluetooth SIG submodule. The most important changes are grouped below.

Documentation and Project Guidance:

  • Major rewrite and reorganization of .github/copilot-instructions.md to clarify project layout, non-negotiable rules, workflow, quality gates, and authoritative references. The new version is clearer, more concise, and easier to follow for contributors.
  • Addition of CLAUDE.md as a quick-start and guidance document, directing contributors to canonical rules and focused instructions.
  • Improved specificity and clarity in documentation instructions, including Sphinx cross-reference syntax and diagram guidance in .github/instructions/documentation.instructions.md.

Architecture and Implementation Rules:

  • Updated .github/instructions/bluetooth-gatt.instructions.md and .github/instructions/python-implementation.instructions.md to emphasize the prohibition of hardcoded UUIDs, clarify type safety requirements, and detail implementation patterns for characteristics. [1] [2]
  • Enhanced .github/instructions/testing.instructions.md with a clear characteristic test pattern, edge case requirements, and improved coverage policy.

Codebase and Submodule Updates:

  • Updated the bluetooth_sig submodule to a newer commit, ensuring the latest SIG YAML data is used.
  • Fixed imports in several files to import CharacteristicName from the correct module (gatt.characteristics.registry), improving code clarity and correctness. [1] [2] [3]
  • Corrected the characteristic name in Acceleration3DCharacteristic to match the SIG specification.

Tooling and Configuration:

  • Fixed the Python virtual environment path in .vscode/settings.json for proper environment detection.

Cleanup:

  • Removed the unused .github/instructions/memory.instruction.md file.

These changes collectively improve the project's maintainability, onboarding experience, and enforceability of best practices.

Copilot AI review requested due to automatic review settings April 1, 2026 19:28
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds coverage for additional Bluetooth SIG GATT services (and related support types) so the library’s service layer and registry can represent more of the assigned-number catalog consistently.

Changes:

  • Added new service test suites for multiple SIG services using the shared CommonServiceTests contract.
  • Updated shared service test expectations to allow advertisement-only services with zero characteristics.
  • Introduced/updated service/type definitions to support the new services (including BSS split-header encoding).

Reviewed changes

Copilot reviewed 279 out of 280 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/bluetooth_sig/gatt/services/generic_access.py Service characteristic requirement flags for GAP.
src/bluetooth_sig/gatt/services/phone_alert_status.py Service characteristic requirement flags for Phone Alert Status.
src/bluetooth_sig/types/bss.py BSS data types; split-header encode/decode helper used by BSS characteristics.
tests/gatt/services/test_service_common.py Adjusts shared assertions for expected characteristics to support 0-characteristic services.
tests/gatt/services/test_volume_offset_control_service.py Adds service contract tests for Volume Offset Control.
tests/gatt/services/test_volume_control_service.py Adds service contract tests for Volume Control.
tests/gatt/services/test_transport_discovery_service.py Adds service contract tests for Transport Discovery.
tests/gatt/services/test_telephony_and_media_audio_service.py Adds service contract tests for Telephony and Media Audio.
tests/gatt/services/test_telephone_bearer_service.py Adds service contract tests for Telephone Bearer.
tests/gatt/services/test_reconnection_configuration_service.py Adds service contract tests for Reconnection Configuration.
tests/gatt/services/test_ranging_service.py Adds service contract tests for Ranging.
tests/gatt/services/test_published_audio_capabilities_service.py Adds service contract tests for Published Audio Capabilities.
tests/gatt/services/test_public_broadcast_announcement_service.py Adds service contract tests for Public Broadcast Announcement (0 characteristics).
tests/gatt/services/test_physical_activity_monitor_service.py Adds service contract tests for Physical Activity Monitor.
tests/gatt/services/test_object_transfer_service.py Adds service contract tests for Object Transfer.
tests/gatt/services/test_microphone_control_service.py Adds service contract tests for Microphone Control.
tests/gatt/services/test_mesh_proxy_solicitation_service.py Adds service contract tests for Mesh Proxy Solicitation (0 characteristics).
tests/gatt/services/test_mesh_proxy_service.py Adds service contract tests for Mesh Proxy.
tests/gatt/services/test_mesh_provisioning_service.py Adds service contract tests for Mesh Provisioning.
tests/gatt/services/test_media_control_service.py Adds service contract tests for Media Control.

Comment thread src/bluetooth_sig/gatt/services/generic_access.py
Comment thread src/bluetooth_sig/gatt/services/phone_alert_status.py
Comment thread src/bluetooth_sig/types/bss.py
@RonanB96 RonanB96 requested a review from Copilot April 3, 2026 15:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 299 out of 554 changed files in this pull request and generated 12 comments.

Comment thread src/bluetooth_sig/types/bss.py Outdated
Comment thread src/bluetooth_sig/gatt/characteristics/floor_number.py
Comment thread src/bluetooth_sig/gatt/uuid_registry.py Outdated
Comment thread src/bluetooth_sig/gatt/characteristics/registry.py Outdated
Comment thread src/bluetooth_sig/gatt/characteristics/volume_flags.py
Comment thread src/bluetooth_sig/gatt/characteristics/high_voltage.py Outdated
Comment thread tests/gatt/characteristics/test_bss_control_point.py Outdated
Comment thread src/bluetooth_sig/gatt/validation.py
Comment thread src/bluetooth_sig/gatt/characteristics/base.py Outdated
@RonanB96 RonanB96 merged commit ee7cd32 into main Apr 3, 2026
8 checks passed
@RonanB96 RonanB96 deleted the remaining_services branch April 3, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants