Expand SIG characteristic dependency declarations for batch parsing#211
Merged
Conversation
Declare LN Feature and Weight Scale Feature as optional dependencies for Location and Speed and Weight Measurement with dependency tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Documents #192 scope in module docstring and verifies topological batch parse with/out optional LN Feature and Weight Scale Feature dependencies. Co-authored-by: Cursor <cursoragent@cursor.com>
Characteristic test-file coverage requires 1:1 module stems; batch parse tests belong under tests/integration instead. Co-authored-by: Cursor <cursoragent@cursor.com>
Import LNFeatureCharacteristic from ln_feature module and pass bytes to parse_characteristics per API typing. Co-authored-by: Cursor <cursoragent@cursor.com>
Wire optional dependencies to SIG feature-flag checks in _decode_value (cycling-power pattern). Drop redundant integration batch test; extend CommonCharacteristicTests with context validation cases. Co-authored-by: Cursor <cursoragent@cursor.com>
RonanB96
force-pushed
the
fix/issue-192-char-deps
branch
from
f61e2c6 to
54a5c0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_optional_dependenciesfor Location and Speed → LN Feature_optional_dependenciesfor Weight Measurement → Weight Scale Featuredependency_test_datafixtures covering with/without dependency parse pathsTest plan
test_location_and_speed.pyandtest_weight_measurement.pyFixes #192
Made with Cursor