-
Notifications
You must be signed in to change notification settings - Fork 2
chore:update reqs #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore:update reqs #134
Conversation
DenTray
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RGO230 please also:
- Remove https://github.com/RonasIT/laravel-empty-project/blob/development/app/Http/Middleware/CheckVersionMiddleware.php as it moved to the helpers package
- Remove https://github.com/RonasIT/laravel-empty-project/blob/development/app/Http/Middleware/ClearVersion.php as it in helpers now
- Remove https://github.com/RonasIT/laravel-empty-project/blob/development/app/Http/Resources/BaseJsonResource.php as it in helpers now
- Remove https://github.com/RonasIT/laravel-empty-project/blob/development/app/Support/Version.php as it in helpers now
- Update https://github.com/RonasIT/laravel-empty-project/blob/development/config/entity-generator.php
composer.json
Outdated
| "phpunit/phpunit": "^12.3", | ||
| "ronasit/laravel-entity-generator": "^3.3", | ||
| "ronasit/laravel-project-initializator": "^0.1.4" | ||
| "ronasit/laravel-project-initializator": "^0.1.9" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "ronasit/laravel-project-initializator": "^0.1.9" | |
| "ronasit/laravel-project-initializator": "^0.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates dependencies and refactors the application to use external versioning and resource functionality from the ronasit/laravel-helpers package, removing locally implemented versions of these features.
- Updates multiple package versions in composer.json, including Laravel framework and related dependencies
- Replaces custom versioning middleware and support classes with
RonasIT\Supportpackage implementations - Updates test fixtures to include a new "page" field in pagination link objects
- Removes local
BaseJsonResourceclass in favor of the package'sBaseResource
Reviewed Changes
Copilot reviewed 30 out of 31 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates dependency versions for Laravel framework, testing tools, and related packages |
| bootstrap/app.php | Replaces custom versioning middleware with package implementation |
| routes/api.php | Removes clear_version middleware from route prefix |
| config/entity-generator.php | Cleans up outdated configuration paths and stub references |
| app/Support/Version.php | Removes local Version support class (now provided by package) |
| app/Http/Middleware/ClearVersion.php | Removes custom middleware (replaced by package) |
| app/Http/Middleware/CheckVersionMiddleware.php | Removes custom middleware (replaced by package) |
| app/Http/Resources/BaseJsonResource.php | Removes local base resource class (replaced by package) |
| app/Http/Resources/**/*.php | Updates resource classes to extend package's BaseResource |
| tests/fixtures/**/*.json | Adds "page" field to pagination link objects in test fixtures |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
No description provided.