190 change get namespace method #215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pace_method # Conflicts: # src/Generators/ResourceGenerator.php
refs: #190
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the namespace generation logic across all generator classes. The main change is renaming the getNamespace() method to generateNamespace() and modifying it to accept the actual path string directly instead of a config key, along with moving path validation logic to the constructor.
Key changes:
- Renamed
getNamespace()togenerateNamespace()and changed parameters to accept paths directly instead of config keys - Moved path validation logic from inline checks to a new
checkConfigHasCorrectPaths()method called in the constructor - Updated all generator classes to pass
$this->paths[...]directly togenerateNamespace()instead of config keys - Added
'translations'entry to theLOVER_CASE_DIRECTORIES_MAPconstant
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Generators/EntityGenerator.php | Core refactoring: renamed method, updated parameter handling, moved validation logic to constructor, added translations path mapping |
| src/Generators/TestsGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/ServiceGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/SeederGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/ResourceGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/RequestsGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/RepositoryGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/NovaTestGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/NovaResourceGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/ModelGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/FactoryGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/ControllerGenerator.php | Updated calls to use generateNamespace() with direct path references |
| src/Generators/AbstractTestsGenerator.php | Updated calls to use generateNamespace() with direct path references |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DenTray
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.