configure github 'builds'#2
Open
zeffgo wants to merge 7 commits into
Open
Conversation
zeffgo
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RonenMars
reviewed
Aug 15, 2023
| @@ -1,4 +1,4 @@ | |||
| import React from 'react'; | |||
Owner
There was a problem hiding this comment.
React must be here, because of our ESLint rules:
https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/react-in-jsx-scope.md
Owner
There was a problem hiding this comment.
Maybe we should disable this ESLint rule as described here:
https://kinsta.com/knowledgebase/react-must-be-in-scope-when-using-jsx/
RonenMars
reviewed
Aug 15, 2023
| @@ -1,6 +1,4 @@ | |||
| import React from 'react'; | |||
Owner
There was a problem hiding this comment.
Same comment as before, also the two lines must be in a different lines :)
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
RonenMars
requested changes
Aug 15, 2023
Owner
RonenMars
left a comment
RonenMars
left a comment
There was a problem hiding this comment.
Please put back the React imports, but except it:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
we can have build & test checks for free as far as we dont go crazy, why not?