Skip to content

Fix on GIt Quickshell#34

Merged
Ronin-CK merged 1 commit intoRonin-CK:mainfrom
luyu-wu:main
Apr 27, 2026
Merged

Fix on GIt Quickshell#34
Ronin-CK merged 1 commit intoRonin-CK:mainfrom
luyu-wu:main

Conversation

@luyu-wu
Copy link
Copy Markdown
Contributor

@luyu-wu luyu-wu commented Apr 21, 2026

Recently this tool shows a grey screen on git Quickshell. Unsure of the quickshell commit that caused this, but after diagnosing the problem is like this:

  • Screencopy is run asynchronously, only getting a frame ~80ms later
  • PanelWindow is opaque by default (white)
  • This causes a the user to not be able to see the screen when screenshotting.

This PR is a sketchy solution to these. The PanelWindow's color is set to "transparent", this is fine.
However, because the Screencopy lags, it captures the dimming and toolbars in the preview. To circumvent this, we delay the toolbars and dimming by using a isReady timer.

I think there may be a more elegant solution than this, but it works well enough for me! Feel free to make any changes.

anchors.fill: parent
z: -1
}

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can bind isReady directly to the view's content state:

property bool isReady: screencopy.hasContent ScreencopyView { id: screencopy captureSource: root.targetScreen anchors.fill: parent z: -1 }
you can then remove the timer block entirely

Copy link
Copy Markdown
Owner

@Ronin-CK Ronin-CK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @luyu-wu! Great catch on the grey screen issue.

I've accepted the fix but replaced the Timer with a more reactive ScreencopyView.hasContent binding to make it even smoother.

@Ronin-CK Ronin-CK merged commit 30b53b0 into Ronin-CK:main Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants