[BUG] Roo does not auto-execute commands even when the auto-approve feature is enabled.

[AI-Vectoring]

Problem (one or two sentences)

[BUG] In code mode (haven't tested others) Roo does not automatically execute commands and asks for approval even when the auto-approve feature is enabled.

Context (who is affected and when)

DEB13, VSC, latest roo. (but this was happening in older versions too).

Reproduction steps

Enable auto-approve and enable all or enable execution.
Interact with code mode, ask it for a task that requires running commands.

Expected result

Roo executes commands in the console automatically.

Actual result

Roo asks for permission even with auto-approve enabled.

Variations tried (optional)

No response

App Version

latest

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote-v0]

I've analyzed this issue and here's my findings and proposed implementation plan:

Root Cause Analysis:

The auto-approval flow for command execution in src/core/auto-approval/index.ts (lines 114-130) works as follows:

1. The master toggle autoApprovalEnabled must be true
2. The execute sub-toggle alwaysAllowExecute must be true
3. The command must also match a prefix in the allowedCommands list

The problem is in step 3: when alwaysAllowExecute is enabled but allowedCommands is empty (which is the default), the getCommandDecision() function in src/core/auto-approval/commands.ts returns "ask_user" for every command because no prefix match is found in either the allow or deny list. This means enabling "Execute" auto-approval has no effect unless the user has also manually configured specific allowed command prefixes (or a * wildcard).

The "Select All" button in the auto-approve dropdown enables alwaysAllowExecute but does not add any entries to allowedCommands, creating a confusing situation where the toggle shows "enabled" but commands still require approval.

Proposed Fix:

Modify checkAutoApproval() in src/core/auto-approval/index.ts so that when alwaysAllowExecute is true and allowedCommands is empty (no explicit allowlist configured), commands are auto-approved by default (unless they match an entry in deniedCommands). This makes the toggle behavior match user expectations: enabling "Execute" means commands will be auto-approved.

Specifically:

1. In the ask === "command" branch of checkAutoApproval(), when alwaysAllowExecute is true and allowedCommands is empty and deniedCommands is empty, return { decision: "approve" } directly
2. When allowedCommands is empty but deniedCommands is not empty, only check the deny list (approve if not denied)
3. Keep the existing behavior when allowedCommands has entries (prefix matching with longest match wins)
4. Add corresponding unit tests

This preserves backward compatibility for users who have configured explicit allow/deny lists, while fixing the case where a user simply enables the toggle and expects it to work.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.

[Rexarrior]

+++
A lot of problem with autoapprove commands in last several months