[BUG] The Skill I added has disappeared

[linaki-o]

Problem (one or two sentences)

The Skill I added has disappeared

Context (who is affected and when)

I added a Skill, then switched to the chat screen and back to the Skills screen, and the one I just added disappeared. I already had a Skill created earlier—does it only support having one Skill at a time?

Reproduction steps

1. I added a Skill,
2. then switched to the chat screen
3. and back to the Skills screen,
4. and the one I just added disappeared.
   (I already had a Skill created earlier—does it only support having one Skill at a time?)

Expected result

The Skill I added comes back

Actual result

The Skill I added disappeared

Variations tried (optional)

No response

App Version

Version: 3.53.0 (44f6bba)

API Provider (optional)

None

Model Used (optional)

No response

Roo Code Task Links (optional)

No response

Relevant logs or errors (optional)

[roomote-v0]

I have analyzed this issue and identified a likely root cause: a race condition in SkillsManager.discoverSkills().

Root Cause Analysis

The discoverSkills() method in src/services/skills/SkillsManager.ts (line 43) starts by calling this.skills.clear(), wiping the in-memory Map. It then gradually rebuilds it by scanning multiple directories, with await points between each skill directory scan. This creates a window where the Map is empty or partially populated.

When a user creates a skill, createSkill() calls discoverSkills(), and then the file watcher also fires and calls discoverSkills() again asynchronously. If the user navigates away from the Settings screen and back during this window, the requestSkills handler reads from the Map via getSkillsMetadata() and may see an incomplete list -- missing the newly added skill (or potentially other skills).

The key sequence:

1. File watcher fires, calls discoverSkills() which runs this.skills.clear()
2. Scanning begins with await points between each entry
3. User navigates back to Settings, triggering requestSkills
4. getSkillsMetadata() reads the partially-populated Map
5. User sees only some skills (the ones scanned before the read)

Proposed Fix

Change discoverSkills() to build the new skills in a temporary Map, then atomically swap it in at the end. This eliminates the window where the Map is empty or partially populated.

1. Modify discoverSkills() to create a local newSkills Map and swap this.skills = newSkills only after all scanning is complete
2. Modify scanSkillsDirectory() and loadSkillMetadata() to accept a target Map parameter instead of writing directly to this.skills
3. Update existing tests to verify the atomic swap behavior (no intermediate empty state)

This is a minimal, low-risk change -- only the internal plumbing of discoverSkills changes, with no impact on the public API or UI.

Please mention @roomote in a comment saying that you approve this plan, and I'll proceed with the implementation.