Skip to content

feat: remove Enable URL context and Enable Grounding with Google search checkboxes#11253

Merged
mrubens merged 1 commit intomainfrom
feat/remove-url-context-grounding-checkboxes
Feb 6, 2026
Merged

feat: remove Enable URL context and Enable Grounding with Google search checkboxes#11253
mrubens merged 1 commit intomainfrom
feat/remove-url-context-grounding-checkboxes

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Feb 6, 2026

Related GitHub Issue

N/A - cleanup task requested by maintainers.

Roo Code Task Context (Optional)

View task on Roo Code Cloud

Description

Removes the "Enable URL context" and "Enable Grounding with Google search" checkboxes from Gemini and Vertex provider settings, along with all associated logic and translations.

Changes:

  • Removed enableUrlContext and enableGrounding fields from both the Vertex and Gemini provider schemas in packages/types/src/provider-settings.ts
  • Removed the checkbox UI elements from Gemini.tsx and Vertex.tsx components
  • Removed the simplifySettings prop from Gemini and Vertex components (it was only used for the removed checkboxes)
  • Removed URL context and Google Search tool injection from completePrompt methods in both gemini.ts and vertex.ts providers
  • Removed urlContext and groundingSearch translation keys from all 18 locale settings.json files
  • Updated all related test files to reflect the removal

Note: The grounding metadata extraction logic (extractGroundingSources, extractCitationsOnly) and the grounding stream events in createMessage are preserved, as they handle server-side grounding data that may still be returned by the API regardless of these client-side settings.

Test Procedure

  • All existing tests updated and passing (37 tests across 5 test files)
  • Lint and type checks pass across the entire monorepo
  • Manual verification: the removed checkboxes no longer appear in Gemini/Vertex provider settings

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Testing: New and/or updated tests have been added to cover my changes (if applicable).
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

  • No documentation updates are required.

Additional Notes

29 files changed, 33 insertions(+), 672 deletions(-). Net removal of ~639 lines of code.


Important

Removed "Enable URL context" and "Enable Grounding with Google search" checkboxes and related logic from UI, schemas, and tests.

  • Behavior:
    • Removed "Enable URL context" and "Enable Grounding with Google search" checkboxes from Gemini.tsx and Vertex.tsx.
    • Removed enableUrlContext and enableGrounding fields from provider schemas in provider-settings.ts.
    • Removed related logic from completePrompt methods in gemini.ts and vertex.ts.
  • Translations:
    • Removed urlContext and groundingSearch keys from all locale settings.json files.
  • Tests:
    • Updated tests in gemini-handler.spec.ts and vertex.spec.ts to reflect checkbox removal.

This description was created by Ellipsis for 9957ddb. You can customize this summary. It will automatically update as commits are pushed.

…ch checkboxes

Remove the "Enable URL context" and "Enable Grounding with Google search"
checkboxes from Gemini and Vertex provider settings, along with:

- enableUrlContext and enableGrounding fields from provider settings schemas
- URL context and Google Search tool injection in completePrompt methods
- Associated translation keys from all 18 locale files
- Related test cases updated to reflect the removal
- simplifySettings prop removed from Gemini and Vertex components
  (it was only used for the removed checkboxes in those components)
@roomote
Copy link
Contributor Author

roomote bot commented Feb 6, 2026

Rooviewer Clock   See task

No issues found. The removal is clean and complete -- all references to enableUrlContext, enableGrounding, and associated translation keys have been fully removed from schemas, providers, UI components, and tests. The grounding metadata extraction logic is correctly preserved for server-side data that may still be returned by the API.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens marked this pull request as ready for review February 6, 2026 14:35
@mrubens mrubens requested review from cte, jr and mrubens as code owners February 6, 2026 14:35
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused labels Feb 6, 2026
@roomote
Copy link
Contributor Author

roomote bot commented Feb 6, 2026

Rooviewer Clock   See task

No issues found. The removal is clean and thorough -- all references to enableUrlContext, enableGrounding, and the associated geminiParameters translation keys have been fully removed from schemas, provider logic, UI components, tests, and all 18 locale files. The grounding metadata extraction in createMessage is correctly preserved for server-side data.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@mrubens mrubens merged commit 2053de7 into main Feb 6, 2026
25 checks passed
@mrubens mrubens deleted the feat/remove-url-context-grounding-checkboxes branch February 6, 2026 14:43
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 6, 2026
@github-actions github-actions bot mentioned this pull request Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants