Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Feb 10, 2026

Important

Fixes task resumption in api.ts by handling webview launch status and updating sendMessage for headless mode.

  • Behavior:
    • In api.ts, resumeTask() now waits for webview launch and logs if not launched, continuing in headless mode.
    • sendMessage() checks if webview is launched; if not, submits message directly to task channel.
  • Utilities:
    • Adds waitForWebviewLaunch() in api.ts to wait for webview launch with a timeout.
  • Tests:
    • Updates api-send-message.spec.ts to mock getCurrentTask and test sendMessage behavior with and without webview launch.

This description was created by Ellipsis for 9ac20a2. You can customize this summary. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Feb 10, 2026
@roomote
Copy link
Contributor

roomote bot commented Feb 10, 2026

Rooviewer Clock   See task

Re-reviewed after 9ac20a2. The test mock fix resolves the getCurrentTask breakage. One item remains open.

  • getCurrentTask() called unconditionally in sendMessage breaks existing test mocks -- fixed by adding the mock to the provider object
  • No test coverage for the new headless fallback paths in sendMessage or resumeTask
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@cte cte merged commit b029245 into main Feb 10, 2026
10 checks passed
@cte cte deleted the cte/api-task-resume-fix branch February 10, 2026 08:28
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant