-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a setAlwaysAllowBrowser checkbox to settings #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to cebcbfff889461c25c5d848a4ade35475f9f234f in 1 minute and 5 seconds
More details
- Looked at
345lines of code in7files - Skipped
1files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. src/core/webview/ClineProvider.ts:531
- Draft comment:
The logic for updating global state and Cline instance foralwaysAllowBrowseris repeated for other settings likealwaysAllowReadOnly,alwaysAllowWrite, andalwaysAllowExecute. Consider refactoring to reduce redundancy. - Reason this comment was not posted:
Confidence changes required:50%
The codebase has multiple instances where the same logic is repeated for different settings. This can be refactored to reduce redundancy.
2. src/core/webview/ClineProvider.ts:527
- Draft comment:
Consider using async/await instead of .then() for promise handling to improve readability and maintainability. This is in line with our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Comment was not on a valid diff hunk.
3. src/core/webview/ClineProvider.ts:834
- Draft comment:
Consider using async/await instead of .then() for promise handling to improve readability and maintainability. This is in line with our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_FAavBrKQa9uAnQUq
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
cebcbff to
0346fde
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 0346fde in 2 minutes and 41 seconds
More details
- Looked at
412lines of code in8files - Skipped
1files when reviewing. - Skipped posting
11drafted comments based on config settings.
1. src/core/Cline.ts:875
- Draft comment:
Remove the commented-out regex pattern if it's not needed to avoid confusion. - Reason this comment was not posted:
Confidence changes required:50%
The regex pattern in the comment is incomplete and commented out, which might confuse future developers. It should be removed if not needed.
2. src/core/Cline.ts:1421
- Draft comment:
Consider usingserializeErrorfor error serialization to handle potential circular references safely. - Reason this comment was not posted:
Confidence changes required:50%
The code usesJSON.stringifyto serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. UsingserializeErrorfrom theserialize-errorpackage can help safely serialize errors and objects with circular references.
3. src/core/Cline.ts:1464
- Draft comment:
Consider usingserializeErrorfor error serialization to handle potential circular references safely. - Reason this comment was not posted:
Confidence changes required:50%
The code usesJSON.stringifyto serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. UsingserializeErrorfrom theserialize-errorpackage can help safely serialize errors and objects with circular references.
4. src/core/Cline.ts:1467
- Draft comment:
Consider usingserializeErrorfor error serialization to handle potential circular references safely. - Reason this comment was not posted:
Confidence changes required:50%
The code usesJSON.stringifyto serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. UsingserializeErrorfrom theserialize-errorpackage can help safely serialize errors and objects with circular references.
5. src/core/Cline.ts:872
- Draft comment:
Consider usingserializeErrorfor error serialization to handle potential circular references safely. - Reason this comment was not posted:
Confidence changes required:50%
The code usesJSON.stringifyto serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. UsingserializeErrorfrom theserialize-errorpackage can help safely serialize errors and objects with circular references.
6. src/core/Cline.ts:1440
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Comment was on unchanged code.
7. src/core/webview/ClineProvider.ts:527
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
8. src/core/webview/ClineProvider.ts:834
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
9. src/core/webview/ClineProvider.ts:945
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
10. src/core/webview/ClineProvider.ts:977
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
11. src/core/webview/ClineProvider.ts:1026
- Draft comment:
Consider using async/await instead of .then() for handling promises. This makes the code more readable and maintainable. Refer to our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d581809f9af3fdba09412ef6 - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_kXu0ThHcNoVAlhxS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
Merged changes from #14 to cline/cline#784 |
|
Regarding #14 https://discord.com/channels/1275535550845292637/1275535550845292640/1311045513864417330
|
* fix(marketplace): done should redirect to browse * test(marketplace): update outdated tests * refactor(marketplace): handle opening in non-workspace * feat(marketplace): put behind a feature flag * fix(marketplace): missing translations * fix: solve lint errors, make build-able * fix: use `cwd` instead of `filePaths` for ws detection * fix(marketplace): should dedupe items with same id from multiple registries * fix: tab cycle should not reach hidden content * fix: `mcp` filter --------- Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
* fix(marketplace): done should redirect to browse * test(marketplace): update outdated tests * refactor(marketplace): handle opening in non-workspace * feat(marketplace): put behind a feature flag * fix(marketplace): missing translations * fix: solve lint errors, make build-able * fix: use `cwd` instead of `filePaths` for ws detection * fix(marketplace): should dedupe items with same id from multiple registries * fix: tab cycle should not reach hidden content * fix: `mcp` filter --------- Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
* fix(marketplace): done should redirect to browse * test(marketplace): update outdated tests * refactor(marketplace): handle opening in non-workspace * feat(marketplace): put behind a feature flag * fix(marketplace): missing translations * fix: solve lint errors, make build-able * fix: use `cwd` instead of `filePaths` for ws detection * fix(marketplace): should dedupe items with same id from multiple registries * fix: tab cycle should not reach hidden content * fix: `mcp` filter --------- Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
Important
Add
alwaysAllowBrowsersetting to allow browser actions without confirmation, updating core logic, UI, and messaging components.cline.alwaysAllowBrowsersetting inpackage.jsonto allow browser actions without confirmation.Clineclass inCline.tsto handlealwaysAllowBrowserfor browser actions.ClineProviderinClineProvider.tsto initialize and updatealwaysAllowBrowserstate.alwaysAllowBrowserinSettingsView.tsx.ExtensionStateContext.tsxto managealwaysAllowBrowserstate.WebviewMessage.tsandExtensionMessage.tsto includealwaysAllowBrowsermessage type.Cline.test.tsto testalwaysAllowBrowserbehavior.This description was created by
for 0346fde. It will automatically update as commits are pushed.