Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 22, 2024

Screenshot 2024-11-22 at 1 23 47 PM


Important

Add alwaysAllowBrowser setting to allow browser actions without confirmation, updating core logic, UI, and messaging components.

  • Behavior:
    • Adds cline.alwaysAllowBrowser setting in package.json to allow browser actions without confirmation.
    • Updates Cline class in Cline.ts to handle alwaysAllowBrowser for browser actions.
    • Modifies ClineProvider in ClineProvider.ts to initialize and update alwaysAllowBrowser state.
  • UI:
    • Adds checkbox for alwaysAllowBrowser in SettingsView.tsx.
    • Updates ExtensionStateContext.tsx to manage alwaysAllowBrowser state.
  • Messaging:
    • Updates WebviewMessage.ts and ExtensionMessage.ts to include alwaysAllowBrowser message type.
  • Tests:
    • Updates Cline.test.ts to test alwaysAllowBrowser behavior.

This description was created by Ellipsis for 0346fde. It will automatically update as commits are pushed.

@mrubens mrubens requested a review from stea9499 November 22, 2024 18:25
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cebcbfff889461c25c5d848a4ade35475f9f234f in 1 minute and 5 seconds

More details
  • Looked at 345 lines of code in 7 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. src/core/webview/ClineProvider.ts:531
  • Draft comment:
    The logic for updating global state and Cline instance for alwaysAllowBrowser is repeated for other settings like alwaysAllowReadOnly, alwaysAllowWrite, and alwaysAllowExecute. Consider refactoring to reduce redundancy.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The codebase has multiple instances where the same logic is repeated for different settings. This can be refactored to reduce redundancy.
2. src/core/webview/ClineProvider.ts:527
3. src/core/webview/ClineProvider.ts:834

Workflow ID: wflow_FAavBrKQa9uAnQUq


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@mrubens mrubens force-pushed the always_allow_browser branch from cebcbff to 0346fde Compare November 22, 2024 18:37
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 0346fde in 2 minutes and 41 seconds

More details
  • Looked at 412 lines of code in 8 files
  • Skipped 1 files when reviewing.
  • Skipped posting 11 drafted comments based on config settings.
1. src/core/Cline.ts:875
  • Draft comment:
    Remove the commented-out regex pattern if it's not needed to avoid confusion.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The regex pattern in the comment is incomplete and commented out, which might confuse future developers. It should be removed if not needed.
2. src/core/Cline.ts:1421
  • Draft comment:
    Consider using serializeError for error serialization to handle potential circular references safely.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses JSON.stringify to serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. Using serializeError from the serialize-error package can help safely serialize errors and objects with circular references.
3. src/core/Cline.ts:1464
  • Draft comment:
    Consider using serializeError for error serialization to handle potential circular references safely.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses JSON.stringify to serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. Using serializeError from the serialize-error package can help safely serialize errors and objects with circular references.
4. src/core/Cline.ts:1467
  • Draft comment:
    Consider using serializeError for error serialization to handle potential circular references safely.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses JSON.stringify to serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. Using serializeError from the serialize-error package can help safely serialize errors and objects with circular references.
5. src/core/Cline.ts:872
  • Draft comment:
    Consider using serializeError for error serialization to handle potential circular references safely.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The code uses JSON.stringify to serialize objects for logging or messaging. However, it doesn't handle potential circular references, which can cause runtime errors. Using serializeError from the serialize-error package can help safely serialize errors and objects with circular references.
6. src/core/Cline.ts:1440
7. src/core/webview/ClineProvider.ts:527
8. src/core/webview/ClineProvider.ts:834
9. src/core/webview/ClineProvider.ts:945
10. src/core/webview/ClineProvider.ts:977
11. src/core/webview/ClineProvider.ts:1026

Workflow ID: wflow_kXu0ThHcNoVAlhxS


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@lloydchang
Copy link
Contributor

Merged changes from #14 to cline/cline#784

@lloydchang
Copy link
Contributor

Regarding #14

https://discord.com/channels/1275535550845292637/1275535550845292640/1311045513864417330

The checkbox only applies when the model supports computer use. We only use Sonnet 3.5 at Roo, so things are simpler.

@cte cte deleted the always_allow_browser branch February 1, 2025 06:16
hannesrudolph pushed a commit that referenced this pull request May 24, 2025
* fix(marketplace): done should redirect to browse

* test(marketplace): update outdated tests

* refactor(marketplace): handle opening in non-workspace

* feat(marketplace): put behind a feature flag

* fix(marketplace): missing translations

* fix: solve lint errors, make build-able

* fix: use `cwd` instead of `filePaths` for ws detection

* fix(marketplace): should dedupe items with same id from multiple registries

* fix: tab cycle should not reach hidden content

* fix: `mcp` filter

---------

Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
elianiva added a commit to elianiva/Roo-Code that referenced this pull request May 24, 2025
* fix(marketplace): done should redirect to browse

* test(marketplace): update outdated tests

* refactor(marketplace): handle opening in non-workspace

* feat(marketplace): put behind a feature flag

* fix(marketplace): missing translations

* fix: solve lint errors, make build-able

* fix: use `cwd` instead of `filePaths` for ws detection

* fix(marketplace): should dedupe items with same id from multiple registries

* fix: tab cycle should not reach hidden content

* fix: `mcp` filter

---------

Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
mrubens pushed a commit that referenced this pull request Jun 11, 2025
* fix(marketplace): done should redirect to browse

* test(marketplace): update outdated tests

* refactor(marketplace): handle opening in non-workspace

* feat(marketplace): put behind a feature flag

* fix(marketplace): missing translations

* fix: solve lint errors, make build-able

* fix: use `cwd` instead of `filePaths` for ws detection

* fix(marketplace): should dedupe items with same id from multiple registries

* fix: tab cycle should not reach hidden content

* fix: `mcp` filter

---------

Co-authored-by: NamesMT <dangquoctrung123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants