Skip to content

Conversation

@KJ7LNW
Copy link
Contributor

@KJ7LNW KJ7LNW commented May 23, 2025

Context

Terminal integration timeout was being capped at 5 seconds regardless of user configuration, causing shell integration to fail prematurely when initialization took longer than 5 seconds.

Implementation

Removed the Math.min call in getShellIntegrationTimeout() that was capping the timeout at the default value of 5000ms, allowing the user-configured timeout value to be respected.

How to Test

  1. Set terminal integration timeout to a value higher than 5 seconds (e.g., 60 seconds)
  2. Run a command that takes longer than 5 seconds to initialize shell integration
  3. Verify that shell integration doesn't fail after 5 seconds but waits for the configured timeout

Fixes #3885
Fixes #3829
Regression from #2820

Get in Touch

Discord: KJ7LNW


Important

Removed timeout cap in getShellIntegrationTimeout() in BaseTerminal.ts to respect user-configured values, fixing premature shell integration failures.

This description was created by Ellipsis for 0701a9d. You can customize this summary. It will automatically update as commits are pushed.

The terminal integration timeout was being capped at the default value of 5 seconds
due to a Math.min call in getShellIntegrationTimeout(), preventing users from
setting longer timeouts. This caused shell integration to fail prematurely when
initialization took longer than 5 seconds.

This change removes the Math.min cap, allowing the user-configured timeout value
to be respected.

Fixes: #3885
Fixes: #3829
Regression from: #2820

Signed-off-by: Eric Wheeler <roo-code@z.ewheeler.org>
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented May 23, 2025

@cte please merge

@cte cte merged commit 8270158 into RooCodeInc:main May 23, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 23, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Terminal integration timeout is capped at 5 seconds roo code ignores terminal integration timeout

2 participants